Skip to content

chore: be more accepting of linter semver updates #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mobilemind merged 1 commit into from
Jan 14, 2026
Merged

chore: be more accepting of linter semver updates #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 72 additions & 62 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@
},
"description": "Project that makes Safari bookmarklets to automagically jump to the corresponding app and more.",
"devDependencies": {
"@eslint/js": "9.39.2",
"@types/node": "25.0.6",
"@typescript-eslint/eslint-plugin": "8.52.0",
"@typescript-eslint/parser": "8.52.0",
"eslint": "9.39.2",
"eslint-plugin-security": "3.0.1",
"globals": "17.0.0",
"terser": "5.44.1",
"typescript": "5.9.3"
"@eslint/js": "^9.39.2",
"@types/node": "~25.0.7",
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @types/node package was updated from 25.0.6 to 25.0.7 as part of this change. This appears to be an unintentional version bump that goes beyond just adding semver ranges. If the goal is only to "be more accepting of linter semver updates," the version should remain at 25.0.6 with the ~ prefix (which would be ~25.0.6), not update to 25.0.7. Consider whether this version update was intentional or if it should be reverted to maintain the scope of this PR as purely a semver range configuration change.

Suggested change
"@types/node": "~25.0.7",
"@types/node": "~25.0.6",

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

@mobilemind mobilemind Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I reject this suggestion. The change to @types/node ~25.0.7 is intentional

"@typescript-eslint/eslint-plugin": "^8.52.0",
"@typescript-eslint/parser": "^8.52.0",
"eslint": "^9.39.2",
"eslint-plugin-security": "^3.0.1",
Comment on lines +12 to +17
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent semver range strategy across dependencies. Some use caret (^) for minor updates while others use tilde (~) for patch-only updates. Consider establishing a consistent policy:

  • Caret (^) is used for: @eslint/js, @typescript-eslint/*, eslint, eslint-plugin-security
  • Tilde (~) is used for: @types/node, globals, terser, typescript

For better predictability and to avoid unexpected breaking changes, consider using tilde (~) consistently for all dev dependencies, or document the rationale for when each range type should be used (e.g., tilde for build tools that could affect output, caret for linting tools that only affect development).

Suggested change
"@eslint/js": "^9.39.2",
"@types/node": "~25.0.7",
"@typescript-eslint/eslint-plugin": "^8.52.0",
"@typescript-eslint/parser": "^8.52.0",
"eslint": "^9.39.2",
"eslint-plugin-security": "^3.0.1",
"@eslint/js": "~9.39.2",
"@types/node": "~25.0.7",
"@typescript-eslint/eslint-plugin": "~8.52.0",
"@typescript-eslint/parser": "~8.52.0",
"eslint": "~9.39.2",
"eslint-plugin-security": "~3.0.1",

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

@mobilemind mobilemind Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I reject the suggestion. The intent is tilde for build tools that could affect output, caret for linting tools that only affect development.

"globals": "~17.0.0",
"terser": "~5.44.1",
"typescript": "~5.9.3"
},
"engines": {
"node": ">=24.12.0",
Expand Down
Loading