chore: update linter, cleanup Copilot AI slop #236
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions dependencies and adds a CI summary job, though it ironically introduces formatting inconsistencies that contradict the "cleanup" goal stated in the title.
- Updates
actions/cachefrom v4 to v5 in the linter workflow - Adds a
ci-successsummary job to ensure all matrix tests pass before considering CI complete - Introduces extra spaces in YAML field separators in multiple locations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/linter.yml | Updates actions/cache from v4 to v5 |
| .github/workflows/ci.yml | Adds ci-success summary job and introduces spacing inconsistencies in YAML formatting across multiple fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.github/workflows/ci.yml
Outdated
| } | ||
| - name: "Run Tests" | ||
| - name: "Run Tests" |
There was a problem hiding this comment.
Extra space added after the colon in the 'name:' field. This introduces inconsistent YAML formatting compared to the rest of the workflow file. Remove the extra space to maintain consistent formatting.
| - name: "Run Tests" | |
| - name: "Run Tests" |
.github/workflows/ci.yml
Outdated
| steps: | ||
| - name: Check build matrix success | ||
| if: needs.build.result != 'success' | ||
| run: exit 1 |
There was a problem hiding this comment.
Extra space added after the colon in the 'run:' field. This introduces inconsistent YAML formatting compared to the rest of the workflow file. Remove the extra space to maintain consistent formatting.
| run: exit 1 | |
| run: exit 1 |
.github/workflows/ci.yml
Outdated
|
|
||
| - name: "Use Node.js ${{ matrix.node-version }}" | ||
| uses: actions/setup-node@v6 | ||
| uses: actions/setup-node@v6 |
There was a problem hiding this comment.
Extra space added after the colon in the 'uses:' field. This introduces inconsistent YAML formatting compared to the rest of the workflow file. Remove the extra space to maintain consistent formatting.
| uses: actions/setup-node@v6 | |
| uses: actions/setup-node@v6 |
.github/workflows/ci.yml
Outdated
| # which are user's responsibility, not ours | ||
| npm audit --omit=dev --audit-level=moderate || { | ||
| echo "⚠️ Vulnerabilities found in peerDependencies (expected: grunt's js-yaml)" | ||
| echo "⚠️ Vulnerabilities found in peerDependencies (expected: grunt's js-yaml)" |
There was a problem hiding this comment.
Extra space added after the colon in the echo message. While this doesn't break functionality, it introduces inconsistent spacing in the error message. Remove the extra space to maintain consistent formatting.
| echo "⚠️ Vulnerabilities found in peerDependencies (expected: grunt's js-yaml)" | |
| echo "⚠️ Vulnerabilities found in peerDependencies (expected: grunt's js-yaml)" |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Check build matrix success | ||
| if: needs.build.result != 'success' | ||
| run: exit 1 | ||
| - name: Success |
There was a problem hiding this comment.
The "Success" step should have a condition to only run when the build job succeeds. Currently, without a condition, this step will be attempted regardless of whether the previous step failed. Add if: needs.build.result == 'success' to ensure this step only runs when all matrix jobs pass.
| - name: Success | |
| - name: Success | |
| if: needs.build.result == 'success' |
chore: update linter, cleanup Copilot AI slop