Approximate percentiles using t-digest#76
Open
ukazap wants to merge 1 commit intomobius-home:mainfrom
Open
Conversation
Collaborator
|
@ukazap thank you for this! I have been pulled off on other projects for a bit and I am circling back around to Mobius. I like what you have done, I am just considering the impact of including a library that hasn't been touched since 2016 into the project. |
|
From a quick glance I like the look of it! It's a simple estimator and seems to have been widely implemented elsewhere and in other languages. Actual code is quite short. Main issue seems to be the use of one external dependency, which obviously could age... Does it trigger any warnings? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #75