[WIP] Django 2.0 support#26
Open
maiksprenger wants to merge 3 commits into
Open
Conversation
Member
|
Hi! Thank you for the contribution. Do you think we can add a pytest marker for the cms related tests and skip them in Django 2? |
Unfortunately, this still breaks with Django 2.0, so it's no use :(
Author
|
@stephrdev Unfortunately that won't be easy, because we'd have to prevent any imports from Django CMS. It breaks on collection when importing CMS's page model. It would mean removing |
Member
|
Alright. Lets hope that Django 2 support lands in Django-CMS soonish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project with Django 2.0 and noted that
barbequedoes not yet support Django 2.0. I was hopeful and thought it'd be easy to get it to work with Django 2.0 and started a pull request. But unfortunately django-cms is not yet compatible with 2.0, and hence the tests fail.I hope that my work still provides a bit of value, and hence opened this PR so you can pick any commits you deem useful, @stephrdev.
FWIW, I think the non-CMS parts of
barbequeshould work with Django 2.0 just fine. I'll report if I discover otherwise.