Audit fixes batch 7: reject oversized peer list responses#144
Merged
adequatelimited merged 2 commits intomasterfrom Apr 6, 2026
Merged
Audit fixes batch 7: reject oversized peer list responses#144adequatelimited merged 2 commits intomasterfrom
adequatelimited merged 2 commits intomasterfrom
Conversation
Closes #107 A peer responding to OP_GET_IPL could send up to 65535 bytes of IP data (word16 len field). The consumer loop in scan_quorum() is bounded by netplistidx < 1024, but the excess data still causes unnecessary iteration. Added a check rejecting responses where len exceeds RPLISTLEN * sizeof(word32) — the maximum a legitimate node would ever send. Added TODO noting that received peer IPs should be treated as unverified candidates rather than trusted immediately.
[F-29] fix(network): reject oversized peer list responses in get_ipl()
adequatelimited
added a commit
that referenced
this pull request
Apr 13, 2026
Audit fixes batch 7: reject oversized peer list responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seventh batch of audit remediation. One fix.
Changes
Testing