fix: Fix MySQL deadlock issues with high-concurrency email sending#64
Merged
Conversation
Add comprehensive solution for deadlock errors that occur when sending many emails with multiple workers and threads (e.g., 8 workers × 10 threads). Changes include: - Add 4 composite database indexes to reduce row locking during updates - Implement automatic retry with exponential backoff for deadlock errors - Optimize batch updates to process in smaller chunks (100 messages) - Add reduced lock timeout for batchable message queries - Include comprehensive documentation and MySQL configuration recommendations This resolves the issue where messages would show as 'Sent' then immediately transition to 'Error' status due to database deadlocks under high load.
- Add logged method to TestLogger for easier test assertions - Add deadlock_sleep wrapper method to make sleep mockable in tests - Fix test mocking to properly handle deadlock retries and backoff - Update test expectations to correctly access MAX_DEADLOCK_RETRIES constant - All 1449 tests now pass successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive solution for deadlock errors that occur when sending many emails with multiple workers and threads (e.g., 8 workers × 10 threads).
Changes include:
This resolves the issue where messages would show as 'Sent' then immediately transition to 'Error' status due to database deadlocks under high load.