[Server] Change visibility of StreamableHttpTransport methods to protected#143
Merged
Merged
Conversation
…ges` to protected
Contributor
Author
<?php
use \Mcp\Server\Transport\StreamableHttpTransport as BaseStreamableHttpTransport;
use Psr\Http\Message\ResponseFactoryInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\StreamFactoryInterface;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Symfony\Component\Uid\Uuid;
use Workerman\Connection\TcpConnection;
use Workerman\Protocols\Http\ServerSentEvents;
class StreamableHttpTransport extends BaseStreamableHttpTransport
{
private readonly TcpConnection $connection;
/**
* @param array<string, string> $corsHeaders
*/
public function __construct(
private readonly ServerRequestInterface $request,
?ResponseFactoryInterface $responseFactory = null,
?StreamFactoryInterface $streamFactory = null,
array $corsHeaders = [],
LoggerInterface $logger = new NullLogger(),
) {
$this->connection = $request->getAttribute(TcpConnection::class);
parent::__construct($request, $responseFactory, $streamFactory, $corsHeaders, $logger);
}
protected function handleFiberTermination(): void
{
$finalResult = $this->sessionFiber->getReturn();
if (null !== $finalResult) {
try {
$encoded = json_encode($finalResult, \JSON_THROW_ON_ERROR);
$this->connection->send(new ServerSentEvents([
'event' => 'message',
'data' => $encoded,
]));
} catch (\JsonException $e) {
$this->logger->error('SSE: Failed to encode final Fiber result.', ['exception' => $e]);
}
}
$this->sessionFiber = null;
}
protected function flushOutgoingMessages(?Uuid $sessionId): void
{
$messages = $this->getOutgoingMessages($sessionId);
foreach ($messages as $message) {
$this->connection->send(new ServerSentEvents([
'event' => 'message',
'data' => $message['message'],
]));
}
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, I am integrating this SDK with

webmanframework. When usingClientGatewayto send logs, I noticed that the messages are being output to the console, because webman framework starts multiple processes through the console and creates httpserver via socket, so it outputs to the console. Now I need to extendStreamableHttpTransportto send the results to the stream instead.Breaking Changes
No breaking changes
Types of changes
Checklist