[Server] Add meta parameter to addTool and addResource methods#144
Merged
chr-hertel merged 1 commit intoNov 12, 2025
Merged
Conversation
bb-c24
requested review from
CodeWithKyrian,
Nyholm and
chr-hertel
as code owners
bb-c24
force-pushed
the
add_meta_to_add_tool
branch
from
8867289 to
54b5f8e
Compare
bb-c24
changed the title
Member
|
Can you please sign your commit @bb-c24 - thanks already! |
chr-hertel
added
the
needs more work
bb-c24
force-pushed
the
add_meta_to_add_tool
branch
2 times, most recently
from
a476c2e to
c79115a
Compare
bb-c24
force-pushed
the
add_meta_to_add_tool
branch
from
c79115a to
824a31f
Compare
Contributor
Author
|
@chr-hertel done, commit is now signed. Thank you. |
9 tasks
chr-hertel
removed
the
needs more work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
metaparameter toaddTool()andaddResource()methods in the Server Builder to allow passing arbitrary metadata when manually registering tools and resources.Motivation and Context
The internal array definitions for
$toolsand$resourcesalready includedmeta: ?array<string, mixed>in their type definitions, but the correspondingaddTool()andaddResource()methods did not expose this parameter. This inconsistency meant that users could not pass metadata when manually registering tools and resources, even though the infrastructure to support it was already in place.This change brings the public API in line with the internal data structures and provides feature parity with the discovery-based registration system.
How Has This Been Tested?
compact()calls include the newmetaparameterBreaking Changes
None. This is a backward-compatible change as the
metaparameter is optional and defaults tonull.Types of changes
Checklist
Additional context
This change only affects the
addTool()andaddResource()methods. TheaddResourceTemplate()andaddPrompt()methods also havemetain their array definitions but were not modified in this PR. These could be addressed in a follow-up PR if needed for consistency.