charts: add pull_config options in charts(#22)

[rayne-Li]

add pull_config in chart #22

[gemini-code-assist]

Summary of Changes

Hello @rayne-Li, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the model-csi-driver Helm chart by introducing a flexible pull_config option. This new feature allows users to define custom configurations for pulling artifacts, enabling integration with external tools like Dragonfly. Additionally, the .gitignore file has been updated to exclude IDE-specific files.

Highlights

• Helm Chart Configuration: Introduced a new pull_config option within the model-csi-driver Helm chart's configmap.yaml to allow for custom artifact pulling configurations.
• Example pullConfig: Included commented-out examples in values.yaml for pullConfig, demonstrating how to configure a dragonfly_endpoint for artifact pulling.
• Git Ignore Update: Added .idea directory to the .gitignore file to prevent IDE-specific files from being committed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a pull_config option to the Helm chart to allow configuring the pull behavior. The changes are generally good, but there is a critical issue in the configmap.yaml template that would lead to invalid YAML generation. I've provided a fix for that. Additionally, I've suggested improving the values.yaml file by adding a more complete example for the new configuration, which will improve usability for chart consumers. The .gitignore change is correct.

[gemini-code-assist]

The whitespace control {{- will remove the preceding newline and spaces. This will cause pull_config: and its content to be rendered on the same line, resulting in invalid YAML. To fix this, you should remove the - from {{-.

For cleaner formatting, you might also consider using indent instead of nindent and adjusting the template structure, but removing the - is the critical fix.

      {{ toYaml . | nindent 6 }}

[rayne-Li]

• run helm template good with {{ - }}

# helm template model-csi-driver ./model-csi-driver -f model-spec/values-custom.yaml
kind: ConfigMap
metadata:
  name: config
  namespace: model-csi
data:
  config.yaml: |-
    service_name: model.csi.modelpack.org
    root_dir: /mnt/data01/dragonfly/model-csi
    csi_endpoint: unix:///csi/csi.sock
    pull_config:
      concurrency: 32
      dragonfly_endpoint: unix:////var/run/dragonfly/dfdaemon.sock

• an empty line will be added if remove {{ - }}

# Source: model-csi-driver/templates/configmap.yaml
apiVersion: v1
kind: ConfigMap
metadata:
  name: config
  namespace: model-csi
data:
  config.yaml: |-
    service_name: model.csi.modelpack.org
    root_dir: /mnt/data01/dragonfly/model-csi
    csi_endpoint: unix:///csi/csi.sock
    pull_config:
      
      concurrency: 32
      dragonfly_endpoint: unix:////var/run/dragonfly/dfdaemon.sock

[gemini-code-assist]

The example for pullConfig is incomplete and the commenting style is inconsistent. It's good practice to provide commented-out examples for all available fields to guide users. Also, the comment formatting should be consistent, and the double hash ## seems unintentional.

  # pullConfig:
  #   # Number of concurrent downloads.
  #   concurrency: 5
  #
  #   # Path to the directory containing Docker config.json file.
  #   # Defaults to /root/.docker
  #   docker_config_dir: ""
  #
  #   # Endpoint of the Dragonfly dfdaemon.
  #   # e.g. unix:////var/run/dragonfly/dfdaemon.sock
  #   dragonfly_endpoint: ""
  #
  #   # URL of a proxy server to use for pulling images.
  #   proxy_url: ""
  #
  #   # Timeout in seconds for pulling a single layer.
  #   pull_layer_timeout_in_seconds: 300

[rayne-Li]

added in last commit