Migrate from Scrivener to Flop for pagination, filtering, and sorting#523
Migrate from Scrivener to Flop for pagination, filtering, and sorting#523codegen-sh[bot] wants to merge 2 commits intomasterfrom
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
I see a check failed - I'm on it! 🫡 |
|
I've fixed the failing checks in PR #523. The issue was compatibility with Elixir 1.14, which was causing compilation errors in several files:
All tests are now passing across all Elixir/OTP versions. You can see the changes in this commit. 💻 View my work • React 👍 or 👎 |
Description
This PR implements the migration from Scrivener to Flop for pagination, filtering, and sorting in Torch. Flop provides more advanced features while maintaining backward compatibility with existing Scrivener-based code.
Changes
Torch.FlopAdaptermodule to bridge between Scrivener and Flop APIsTorch.Helpers.paginate/4to use Flop internallyTorch.Paginationmodule to use Flop while maintaining backward compatibilityTorch.PaginationView.pagination_from_meta/2Torch.TableView.flop_table_link/3Backward Compatibility
This migration is designed to be backward compatible. Existing code that uses Torch's pagination should continue to work without changes. The following functions maintain backward compatibility:
Torch.Helpers.paginate/4Torch.PaginationmoduleTorch.PaginationView.pagination/1New Features
Flop provides several advanced features not available in Scrivener:
Documentation
Closes #479
💻 View my work • About Codegen