Fix some linter warnings, part 6#218
Merged
kornicameister merged 7 commits intomonasca:masterfrom Oct 16, 2017
Merged
Conversation
timothyb89
reviewed
Sep 18, 2017
kafka-init/create_topics.py
Outdated
| def create_topic(name, partitions, replicas, configs=None): | ||
| if configs: | ||
| arg_pairs = map(lambda item: ['--config', '%s=%s' % item], | ||
| arg_pairs = map(lambda item: ['--config', '{0}={0}'.format(item)], |
Member
There was a problem hiding this comment.
item is a tuple with 2 values, '%' expands this but .format() will not... we don't want '{0}={0}'.format(item) but rather '{0}={1}'.format(*item)
(though to be honest I'm not sure of the utility of converting all % formatting to use .format() anyway...)
timothyb89
requested changes
Sep 18, 2017
Member
timothyb89
left a comment
timothyb89
left a comment
There was a problem hiding this comment.
Kafka topic creation is broken due to a formatting problem
Member
Author
|
Thx @timothyb89 for you comments. |
Contributor
|
some fixes for #191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.