Fix some linter warnings, part 7b#258
Closed
digitalfishpond wants to merge 4 commits intomonasca:masterfrom
Closed
Fix some linter warnings, part 7b#258digitalfishpond wants to merge 4 commits intomonasca:masterfrom
digitalfishpond wants to merge 4 commits intomonasca:masterfrom
Conversation
timothyb89
previously approved these changes
Oct 18, 2017
kornicameister
previously requested changes
Oct 19, 2017
Contributor
kornicameister
left a comment
kornicameister
left a comment
There was a problem hiding this comment.
Let's start bumping versions.
- update build.yml of each module you've modified
- put newer versions into .env
digitalfishpond
force-pushed
the
fix-lint-8b
branch
from
9d5e0fc to
64ab83b
Compare
Contributor
Author
|
Agreed with @kornicameister that after all and henceforth, would be best to make one big pull request at the end of all linter resolution PRs updating .env and build.yaml files to avoid systematic conflicts on the .env file. |
digitalfishpond
force-pushed
the
fix-lint-8b
branch
from
9c9f687 to
d9ec146
Compare
digitalfishpond
dismissed
kornicameister’s stale review
Will do this as part of another PR
timothyb89
approved these changes
Oct 19, 2017
This was referenced Oct 20, 2017
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting #256 to avoid log overload