Fix some linter warnings, part 7c#259
Merged
kornicameister merged 4 commits intomonasca:masterfrom Oct 20, 2017
Merged
Conversation
kornicameister
previously requested changes
Oct 19, 2017
Contributor
kornicameister
left a comment
kornicameister
left a comment
There was a problem hiding this comment.
Let's start bumping versions.
- update build.yml of each module you've modified
- put newer versions into .env
digitalfishpond
force-pushed
the
fix-lint-8c
branch
2 times, most recently
from
8ed0b3e to
091eb69
Compare
digitalfishpond
force-pushed
the
fix-lint-8c
branch
from
091eb69 to
f163721
Compare
Contributor
Author
|
@kornicameister adding .env to every PR generates too many logs again, causing Travis to fail (the reason for making many small PRs), so I will make additional PRs at the very end updating env and build.yml files |
digitalfishpond
dismissed
kornicameister’s stale review
will be making a separate PR for this
Contributor
Author
|
will bump kafka-init version in separate pr to avoid errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
splitting #256 to avoid log overload