Skip to content

PYTHON-5677: ClientEncryption shouldn't try to load mongo crypt shared library #2659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aclark4life wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −2
Open

PYTHON-5677: ClientEncryption shouldn't try to load mongo crypt shared library #2659

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98dba64
MONGOCRYPT-864 do not load crypt_shared in ClientEncryption
kevinAlbs Dec 17, 2025
c64bc2c
Add changelog entry
aclark4life Dec 19, 2025
22c09ec
Address review
aclark4life Dec 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ PyMongo 4.16 brings a number of changes including:
- Fixed return type annotation for ``find_one_and_*`` methods on :class:`~pymongo.asynchronous.collection.AsyncCollection`
and :class:`~pymongo.synchronous.collection.Collection` to include ``None``.
- Added support for NumPy 1D-arrays in :class:`bson.binary.BinaryVector`.
- Fixed a bug in :class:`~pymongo.encryption.ClientEncryption`: ClientEncryption
Copy link
Collaborator

@timgraham timgraham Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested wording: "Prevented ClientEncryption from loading the crypt shared library to fix "MongoCryptError: An existing crypt_shared library is loaded by the application" unless the linked library search path is set."

shouldn't try to load mongo crypt shared library.

Changes in Version 4.15.5 (2025/XX/XX)
--------------------------------------
Expand Down
4 changes: 3 additions & 1 deletion pymongo/asynchronous/encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,10 +714,12 @@ def __init__(
self._io_callbacks: Optional[_EncryptionIO] = _EncryptionIO(
None, key_vault_coll, None, opts
)

# Pass bypass_encryption=True to skip loading crypt_shared.
self._encryption = AsyncExplicitEncrypter(
self._io_callbacks,
_create_mongocrypt_options(
kms_providers=kms_providers, schema_map=None, key_expiration_ms=key_expiration_ms
kms_providers=kms_providers, schema_map=None, key_expiration_ms=key_expiration_ms, bypass_encryption=True
),
)
# Use the same key vault collection as the callback.
Expand Down
7 changes: 6 additions & 1 deletion pymongo/synchronous/encryption.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,10 +707,15 @@ def __init__(
self._io_callbacks: Optional[_EncryptionIO] = _EncryptionIO(
None, key_vault_coll, None, opts
)

# Pass bypass_encryption=True to skip loading crypt_shared.
self._encryption = ExplicitEncrypter(
self._io_callbacks,
_create_mongocrypt_options(
kms_providers=kms_providers, schema_map=None, key_expiration_ms=key_expiration_ms
kms_providers=kms_providers,
schema_map=None,
key_expiration_ms=key_expiration_ms,
bypass_encryption=True,
Copy link
Collaborator

@timgraham timgraham Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline the comment in both places: bypass_encryption=True, # Don't load crypt_shared

),
)
# Use the same key vault collection as the callback.
Expand Down
Loading