Closed
Conversation
* Inline uniforms were a good stopgap to get things up and running but are not supported on all devices. * Perf tests can be run later to determine whether inline uniforms actually improve performance over UBOs and/or push constants, but for now, we decided to just delete it so we do not have to worry about checking for & managing the use of the extension. * This CL puts the VulkanResourceProvider in charge of managing intrinsic constant uniform buffer lifetime. This avoids unnecessary allocations b/w renderpasses and cmd buffers. Change-Id: Ieeb3143eddca932b8fbfd82289a66430ec34cbcc Bug: b/302312586 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/760536 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Nicolette Prevost <nicolettep@google.com>
Follow-up to https://skia-review.googlesource.com/c/skia/+/764969. The idea is to consolidate all code related to tests under a single directory. Bug: b/40045301 Change-Id: I1369e45ed33590b57a9aebce5ba3798694915be3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766678 Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
Bug: b/40045301 Change-Id: I4c8a3b617170024c7cd907c12bdb487befbc68e3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766679 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com>
The symbol defined there is declared in include/private/base, so we can't put it in the src/core module. Change-Id: I60ed9fd6c84c301511986c52b7f4e1349f6d16ab Bug: b/40045064 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766681 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Leandro Lovisolo <lovisolo@google.com> Commit-Queue: Leandro Lovisolo <lovisolo@google.com> Auto-Submit: Kevin Lubick <kjlubick@google.com>
Several of these issues were found because I was running ClangTidy over code which does not normally get tidied, such as Graphite and Metal. Change-Id: I1eb45891e52c59632cffd2e4ff4a44584ceea0d3 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766637 Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/4d77c74a14a0..160b327a9c37 Also rolling transitive DEPS: https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/661f429b11e4392139a6c0630ceb3e3182cdb0f4..5bb595091b3048d20afeb37a9a193350dccd607d https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/7b3466a1f47a9251ac1113efbe022ff016e2f95b..f4bfcd885214675a6a0d7d4df07f52b511e6ea16 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/1532001f7edae559af1988293eec90bc5e2607d5..58eb5fd87d6b60e7766ebdb9160662334d0df6b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC scroggo@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: scroggo@google.com Change-Id: I11da864b4a3badae5cd9d9ba9df9c9270634421e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766916 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://dawn.googlesource.com/dawn.git/+log/90fc3629a642..b665b7fda7cf 2023-10-17 penghuang@chromium.org d3d: append device lost message for all errors 2023-10-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 992a983ef6ab to 2450b59ee797 (9 revisions) 2023-10-17 bajones@chromium.org Remove end2end test skips for Android Qualcomm 2023-10-17 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll DirectX Shader Compiler from 93ad5b31316c to b1b8acdde8e6 (5 revisions) 2023-10-16 lokokung@google.com Revert "Reland "[webgpu-headers] Removes define for signalValue."" 2023-10-16 senorblanco@chromium.org Diagnose some undiagnosed Compat CTS failures. 2023-10-16 dsinclair@chromium.org Move tint writer outputs into the SPIRV request. 2023-10-16 shrekshao@google.com Enable OpenGL backend shader robustness 2023-10-16 senorblanco@chromium.org GLSL validation: don't print error message twice. 2023-10-16 lokokung@google.com Reland "[webgpu-headers] Removes define for signalValue." 2023-10-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 5c0370a84db5 to c40d4dc9fe9c (8 revisions) 2023-10-16 amaiorano@google.com tint: avoid copying iterator 2023-10-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cd6b265c2623 to 992a983ef6ab (1 revision) 2023-10-16 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from beb52a8821f3 to 5c0370a84db5 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-skia-autoroll Please CC cwallez@google.com,lokokung@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Dawn: https://bugs.chromium.org/p/dawn/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Debug-Graphite_Dawn;skia/skia.primary:Test-Mac11-Clang-MacMini9.1-GPU-AppleM1-arm64-Debug-All-Graphite_Dawn;skia/skia.primary:Test-Win10-MSVC-Golo-GPU-QuadroP400-x86_64-Release-All-Graphite_Dawn Bug: None Tbr: lokokung@google.com Change-Id: Iceab46ec3ad6f267abba5dbac18781c2fe4b9911 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766519 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/b7f47ce3bc13..d42ad20d2b50 2023-10-16 eduardoyap@google.com Catch and log non-200 http responses from Chromeperf anomaly endpoint. 2023-10-16 jcgregorio@google.com Update pgx from v4.16.1 to v4.18.1. 2023-10-16 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 77ae6a2042d8 to b7f47ce3bc13 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/infra-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: borenet@google.com Change-Id: If37bca87d4ac387fa244ee4cbc77cf711dd96433 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766923 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/buildbot.git/+log/d42ad20d2b50..0dca655f102b 2023-10-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from b7f47ce3bc13 to d42ad20d2b50 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/sk-tool-skia Please CC borenet@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: borenet@google.com Change-Id: I3f3b34cca171bfaa7ed7dda82de0c5f586c96234 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766520 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://chromium.googlesource.com/angle/angle.git/+log/cd6b265c2623..1ea49a2222e1 2023-10-17 cnorthrop@google.com Move uniform dirty bits to ProgramExecutable 2023-10-17 cclao@google.com Vulkan: Add mapping between FormatID and externalFormat 2023-10-17 cclao@google.com Vulkan: Attempt to fix the perf/mem regression of previous CL 2023-10-16 cclao@google.com Vulkan: Add feature flag for externalFormatResolve 2023-10-16 cclao@google.com Vulkan: Add 8 external format ID for external_format_resolve 2023-10-16 hailinzhang@google.com Vulkan: remove unused image view creation 2023-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from a1a3d457683c to 2545e7b92202 (5 revisions) 2023-10-16 lexa.knyazev@gmail.com Split row and depth pitch computation for compressed formats 2023-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from f719b699697b to a1a3d457683c (10 revisions) 2023-10-16 senorblanco@chromium.org Do not flush normal float constants to zero. 2023-10-16 lexa.knyazev@gmail.com Sync border color on format updates 2023-10-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 345cb7cebed5 to 2de615858387 (749 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-skia-autoroll Please CC jmadill@google.com,scroggo@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE Tbr: scroggo@google.com Test: Test: Dota Underlords Test: Test: ProgramPipelineTest31.ProgramPipelineBindBufferRange Change-Id: I546a6ab44026326784cc2b7daf72080b8c596c85 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766922 Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
Change-Id: Ia88d704a89de7cae96ccc635614291d8d9c0c6bc Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766638 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
Change-Id: Id9d6535ef8b6d92d96fd52f3ad805696ad1f657a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766639 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
These should all have been migrated to Louhi No-Try: true Change-Id: Ibadca73b681b3b7ff8793bbdcf7b7ef384a9b70d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767196 Auto-Submit: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.12.10 to 7.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/traverse</code>'s releases</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <p><strong>NOTE</strong>: This release also re-publishes <code>@babel/core</code>, even if it does not appear in the linked release commit.</p> <p>Thanks <a href="https://github.com/jimmydief"><code>@jimmydief</code></a> for your first PR!</p> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>James Diefenderfer (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a></li> </ul> <h2>v7.23.1 (2023-09-25)</h2> <p>Re-publishing <code>@babel/helpers</code> due to a publishing error in 7.23.0.</p> <h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a> and <a href="https://github.com/RajShukla1"><code>@RajShukla1</code></a> for your first PRs!</p> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/traverse</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.23.0 (2023-09-25)</h2> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15913">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15896">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://github.com/yukukotani"><code>@yukukotani</code></a>)</li> </ul> </li> </ul> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15962">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> </ul> <h4>:nail_care: Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15797">#15797</a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15985">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>:microscope: Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15984">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.22.20 (2023-09-16)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/babel/babel/commit/b4b9942a6cde0685c222eb3412347880aae40ad5"><code>b4b9942</code></a> v7.23.2</li> <li><a href="https://github.com/babel/babel/commit/b13376b346946e3f62fc0848c1d2a23223314c82"><code>b13376b</code></a> Only evaluate own String/Number/Math methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/16033">#16033</a>)</li> <li><a href="https://github.com/babel/babel/commit/ca58ec15cb6dde6812c36997477e44880bec0bba"><code>ca58ec1</code></a> v7.23.0</li> <li><a href="https://github.com/babel/babel/commit/0f333dafcf470f1970083e4e695ced6aec8bead0"><code>0f333da</code></a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15682">#15682</a>)</li> <li><a href="https://github.com/babel/babel/commit/3744545649fdc21688a2f3c97e1e39dbebff0d21"><code>3744545</code></a> Fix linting</li> <li><a href="https://github.com/babel/babel/commit/c7e6806e2194deb36c330f543409c792592b22d4"><code>c7e6806</code></a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15893">#15893</a>)</li> <li><a href="https://github.com/babel/babel/commit/38ee8b4dd693f1e2bd00107bbc1167ce84736ea0"><code>38ee8b4</code></a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15797">#15797</a>)</li> <li><a href="https://github.com/babel/babel/commit/9f3dfd90211472cf0083a3234dd1a1b857ce3624"><code>9f3dfd9</code></a> v7.22.20</li> <li><a href="https://github.com/babel/babel/commit/3ed28b29c1fb15588369bdd55187b69f1248e87d"><code>3ed28b2</code></a> Fully support <code>||</code> and <code>&&</code> in <code>pluginToggleBooleanFlag</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15961">#15961</a>)</li> <li><a href="https://github.com/babel/babel/commit/77b0d7359909c94f3797c24006f244847fbc8d6d"><code>77b0d73</code></a> v7.22.19</li> <li>Additional commits viewable in <a href="https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/google/skia/network/alerts). </details> This is an imported pull request from https://github.com/google/skia/pull/147 GitOrigin-RevId: cdc83ca Change-Id: Ifb1b4b898f3463ad0e6a2f2d03d646c5518d2bf9 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766837 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.12.10 to 7.23.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/releases"><code>@babel/traverse</code>'s releases</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <p><strong>NOTE</strong>: This release also re-publishes <code>@babel/core</code>, even if it does not appear in the linked release commit.</p> <p>Thanks <a href="https://github.com/jimmydief"><code>@jimmydief</code></a> for your first PR!</p> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>Committers: 5</h4> <ul> <li>Babel Bot (<a href="https://github.com/babel-bot"><code>@babel-bot</code></a>)</li> <li>Huáng Jùnliàng (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> <li>James Diefenderfer (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> <li>Nicolò Ribaudo (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a></li> </ul> <h2>v7.23.1 (2023-09-25)</h2> <p>Re-publishing <code>@babel/helpers</code> due to a publishing error in 7.23.0.</p> <h2>v7.23.0 (2023-09-25)</h2> <p>Thanks <a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a> and <a href="https://github.com/RajShukla1"><code>@RajShukla1</code></a> for your first PRs!</p> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/babel/babel/blob/main/CHANGELOG.md"><code>@babel/traverse</code>'s changelog</a>.</em></p> <blockquote> <h2>v7.23.2 (2023-10-11)</h2> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16033">#16033</a> Only evaluate own String/Number/Math methods (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16022">#16022</a> Rewrite <code>.tsx</code> extension when using <code>rewriteImportExtensions</code> (<a href="https://github.com/jimmydief"><code>@jimmydief</code></a>)</li> </ul> </li> <li><code>babel-helpers</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16017">#16017</a> Fix: fallback to typeof when toString is applied to incompatible object (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/16025">#16025</a> Avoid override mistake in namespace imports (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.23.0 (2023-09-25)</h2> <h4>:rocket: New Feature</h4> <ul> <li><code>babel-plugin-proposal-import-wasm-source</code>, <code>babel-plugin-syntax-import-source</code>, <code>babel-plugin-transform-dynamic-import</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15870">#15870</a> Support transforming <code>import source</code> for wasm (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helper-module-transforms</code>, <code>babel-helpers</code>, <code>babel-plugin-proposal-import-defer</code>, <code>babel-plugin-syntax-import-defer</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15878">#15878</a> Implement <code>import defer</code> proposal transform support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-parser</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15845">#15845</a> Implement <code>import defer</code> parsing support (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> <li><a href="https://redirect.github.com/babel/babel/pull/15829">#15829</a> Add parsing support for the "source phase imports" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-generator</code>, <code>babel-helper-module-transforms</code>, <code>babel-parser</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-systemjs</code>, <code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15682">#15682</a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-standalone</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15671">#15671</a> Pass through nonce to the transformed script element (<a href="https://github.com/JLHwung"><code>@JLHwung</code></a>)</li> </ul> </li> <li><code>babel-helper-function-name</code>, <code>babel-helper-member-expression-to-functions</code>, <code>babel-helpers</code>, <code>babel-parser</code>, <code>babel-plugin-proposal-destructuring-private</code>, <code>babel-plugin-proposal-optional-chaining-assign</code>, <code>babel-plugin-syntax-optional-chaining-assign</code>, <code>babel-plugin-transform-destructuring</code>, <code>babel-plugin-transform-optional-chaining</code>, <code>babel-runtime-corejs2</code>, <code>babel-runtime-corejs3</code>, <code>babel-runtime</code>, <code>babel-standalone</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15751">#15751</a> Add support for optional chain in assignments (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-helpers</code>, <code>babel-plugin-proposal-decorators</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15895">#15895</a> Implement the "decorator metadata" proposal (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-traverse</code>, <code>babel-types</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15893">#15893</a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> <li><code>babel-preset-typescript</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15913">#15913</a> Add <code>rewriteImportExtensions</code> option to TS preset (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> <li><code>babel-parser</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15896">#15896</a> Allow TS tuples to have both labeled and unlabeled elements (<a href="https://github.com/yukukotani"><code>@yukukotani</code></a>)</li> </ul> </li> </ul> <h4>:bug: Bug Fix</h4> <ul> <li><code>babel-plugin-transform-block-scoping</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15962">#15962</a> fix: <code>transform-block-scoping</code> captures the variables of the method in the loop (<a href="https://github.com/liuxingbaoyu"><code>@liuxingbaoyu</code></a>)</li> </ul> </li> </ul> <h4>:nail_care: Polish</h4> <ul> <li><code>babel-traverse</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15797">#15797</a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/lorenzoferre"><code>@lorenzoferre</code></a>)</li> </ul> </li> <li><code>babel-plugin-proposal-explicit-resource-management</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15985">#15985</a> Improve source maps for blocks with <code>using</code> declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h4>:microscope: Output optimization</h4> <ul> <li><code>babel-core</code>, <code>babel-helper-module-transforms</code>, <code>babel-plugin-transform-async-to-generator</code>, <code>babel-plugin-transform-classes</code>, <code>babel-plugin-transform-dynamic-import</code>, <code>babel-plugin-transform-function-name</code>, <code>babel-plugin-transform-modules-amd</code>, <code>babel-plugin-transform-modules-commonjs</code>, <code>babel-plugin-transform-modules-umd</code>, <code>babel-plugin-transform-parameters</code>, <code>babel-plugin-transform-react-constant-elements</code>, <code>babel-plugin-transform-react-inline-elements</code>, <code>babel-plugin-transform-runtime</code>, <code>babel-plugin-transform-typescript</code>, <code>babel-preset-env</code> <ul> <li><a href="https://redirect.github.com/babel/babel/pull/15984">#15984</a> Inline <code>exports.XXX =</code> update in simple variable declarations (<a href="https://github.com/nicolo-ribaudo"><code>@nicolo-ribaudo</code></a>)</li> </ul> </li> </ul> <h2>v7.22.20 (2023-09-16)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/babel/babel/commit/b4b9942a6cde0685c222eb3412347880aae40ad5"><code>b4b9942</code></a> v7.23.2</li> <li><a href="https://github.com/babel/babel/commit/b13376b346946e3f62fc0848c1d2a23223314c82"><code>b13376b</code></a> Only evaluate own String/Number/Math methods (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/16033">#16033</a>)</li> <li><a href="https://github.com/babel/babel/commit/ca58ec15cb6dde6812c36997477e44880bec0bba"><code>ca58ec1</code></a> v7.23.0</li> <li><a href="https://github.com/babel/babel/commit/0f333dafcf470f1970083e4e695ced6aec8bead0"><code>0f333da</code></a> Add <code>createImportExpressions</code> parser option (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15682">#15682</a>)</li> <li><a href="https://github.com/babel/babel/commit/3744545649fdc21688a2f3c97e1e39dbebff0d21"><code>3744545</code></a> Fix linting</li> <li><a href="https://github.com/babel/babel/commit/c7e6806e2194deb36c330f543409c792592b22d4"><code>c7e6806</code></a> Add <code>t.buildUndefinedNode</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15893">#15893</a>)</li> <li><a href="https://github.com/babel/babel/commit/38ee8b4dd693f1e2bd00107bbc1167ce84736ea0"><code>38ee8b4</code></a> Expand evaluation of global built-ins in <code>@babel/traverse</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15797">#15797</a>)</li> <li><a href="https://github.com/babel/babel/commit/9f3dfd90211472cf0083a3234dd1a1b857ce3624"><code>9f3dfd9</code></a> v7.22.20</li> <li><a href="https://github.com/babel/babel/commit/3ed28b29c1fb15588369bdd55187b69f1248e87d"><code>3ed28b2</code></a> Fully support <code>||</code> and <code>&&</code> in <code>pluginToggleBooleanFlag</code> (<a href="https://github.com/babel/babel/tree/HEAD/packages/babel-traverse/issues/15961">#15961</a>)</li> <li><a href="https://github.com/babel/babel/commit/77b0d7359909c94f3797c24006f244847fbc8d6d"><code>77b0d73</code></a> v7.22.19</li> <li>Additional commits viewable in <a href="https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/google/skia/network/alerts). </details> This is an imported pull request from https://github.com/google/skia/pull/148 GitOrigin-RevId: 9ea0059 Change-Id: I50df0c164ac0cee53f0468dcf850a39166450a59 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766836 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
This adds a test which would segfault if not for review.skia.org/755577 and review.skia.org/764417. Bug: chromium:1489392 Change-Id: Iaa83005f0a46522e754de536a86ed912a6e84061 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766600 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
This will let our modular Bazel rules land in G3. Change-Id: I404b911b5ae63991ed422b3bd860d19a5afe456c Bug: b/305780908 Bug: b/40045064 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766625 Owners-Override: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
This is only a small subset of the findings, but it's a good starting point. We save a few K of code size from removing unnecessary copies and ref-count bumps. Change-Id: Ibe9c02b1d3cc60592cf7eb689acd9b5d549f8ae6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766634 Auto-Submit: John Stiles <johnstiles@google.com> Reviewed-by: Nicolette Prevost <nicolettep@google.com> Commit-Queue: Nicolette Prevost <nicolettep@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
This reverts commit 222fe6b. Reason for revert: Too slow. Test-Mac10.13-Clang-MacBookPro11.5-CPU-AVX2-x86_64-Debug-All-PDF dm run went from ~6 minutes to ~4 hours. Original change's description: > Reland "[pdf] Simplify filled paths" > > This reverts commit 6ec4fc3. > > Reason for revert: fixing winding and guarding for users > > Original change's description: > > Revert "[pdf] Simplify filled paths" > > > > This reverts commit 1810ba7. > > > > Reason for revert: changes some users expectations, will need to stage. > > > > Original change's description: > > > [pdf] Simplify filled paths > > > > > > Bug: chromium:1449827 > > > Change-Id: If23b343c9ac13caf59a06c1cf68b33ccbe34e59c > > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/717860 > > > Reviewed-by: Brian Osman <brianosman@google.com> > > > Commit-Queue: Ben Wagner <bungeman@google.com> > > > > Bug: chromium:1449827 > > Change-Id: Id988cbe5b21f420157f8cec70ac01862af1cf425 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763418 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Auto-Submit: Ben Wagner <bungeman@google.com> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Bug: chromium:1449827 > Change-Id: Ieaff1132053097c29ee3a5f284a302bd19e11fe7 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/763381 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Ben Wagner <bungeman@google.com> Bug: chromium:1449827 Change-Id: I5d2e98c6fe308438ab02a97347b24fd7c67efd22 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767256 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Ben Wagner <bungeman@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/160b327a9c37..1b161432fcf1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC scroggo@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: scroggo@google.com Change-Id: I1402628b043116f05ea05a2adb4272bbed76148f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767316 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
This reverts commit 64980a5. Reason for revert: This fails to compile with skia_enable_vello_shaders=true, giving the following error: In file included from ../../../tests/graphite/DrawPassTest.cpp:14: In file included from ../../../src/gpu/graphite/RendererProvider.h:16: In file included from ../../../src/gpu/graphite/compute/VelloRenderer.h:15: In file included from ../../../src/gpu/graphite/compute/VelloComputeSteps.h:15: ../../../third_party/vello/cpp/vello.h:9:10: fatal error: 'third_party/vello/src/lib.rs.h' file not found #include "third_party/vello/src/lib.rs.h" ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. This is strange to me because other Graphite source files that include RendererProvider.h compile fine with Vello. Original change's description: > [graphite] Test that failed dst copies don't cause a crash > > This adds a test which would segfault if not for review.skia.org/755577 > and review.skia.org/764417. > > Bug: chromium:1489392 > Change-Id: Iaa83005f0a46522e754de536a86ed912a6e84061 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766600 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: James Godfrey-Kittle <jamesgk@google.com> Bug: chromium:1489392 Change-Id: Ic4a6b6a67d15b25d805be5c17fbde946e7186709 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767416 Reviewed-by: James Godfrey-Kittle <jamesgk@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: James Godfrey-Kittle <jamesgk@google.com>
Files remain empty so they can be added to the Chromium build. Bug: chromium:1488376 Change-Id: Iefa942424d1f76c7252e3af7a9002d45f13a3ec6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/762176 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: ccameron chromium <ccameron@chromium.org>
"src/gpu/graphite/compute/VelloRenderer.h" includes headers from "third_party/vello" that are defined in the ":vello" GN target. This target is currently only an internal dependency in graphite. This header was being included directly in RendererProvider.h which we want to include from graphite unit tests. Rather than expose the ":vello" target to the unit test target just for this reason, this include has now been moved to RendererProvider.cpp. Change-Id: I8d5506cd878dc1109644127bf98d33a5b273c84d Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767556 Reviewed-by: James Godfrey-Kittle <jamesgk@google.com> Commit-Queue: Arman Uguray <armansito@google.com>
This is another small subset of the findings. Change-Id: I9f648dad428cb98fddb5ec34caacdf188474a23e Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767436 Reviewed-by: James Godfrey-Kittle <jamesgk@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: John Stiles <johnstiles@google.com>
For historical reasons, the availability macro for macOS is named __MAC_OS_X_VERSION_MIN_REQUIRED. Fix its use so that deprecated API use is correctly disabled under new versions of macOS. Fixed: b/301115475 Change-Id: I1060c559039deaeff2805fc4f0bfa22e1ef34569 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767616 Commit-Queue: John Stiles <johnstiles@google.com> Reviewed-by: John Stiles <johnstiles@google.com>
In order to make sure that the crossing happens on the segment (instead of beyond the segment), the cross products for both segments need to be checked. Bug: b/297220808 Change-Id: Idc300885fc663a8bfe0fa20a828964583a70efbb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767676 Commit-Queue: Herb Derby <herb@google.com> Reviewed-by: Jim Van Verth <jvanverth@google.com>
We don't have tests for this on our tree yet, but Flutter is using this GN flag. Change-Id: I992d185248d9b74844650301a684d202044eca22 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767559 Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
Bug: b/297546771 Change-Id: Ic97bd16122168b132deec096f839c6fd2347bc17 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767703 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
… to binary. This CL ensures any additional command-line arguments set via Bazel's --test_arg flag are piped all the way through to the C++ binary running on the device under test. This change also works when running a precompiled Android test, that is, when running the result of "bazel build //path/to/some:android_test" directly out of the bazel-bin directory. Bug: b/40045301 Change-Id: Ic4f01ae38e3a56d2cf1a7599b77e257f01cc8c0c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/766680 Commit-Queue: Kevin Lubick <kjlubick@google.com> Auto-Submit: Leandro Lovisolo <lovisolo@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/1b161432fcf1..178effa90318 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/58eb5fd87d6b60e7766ebdb9160662334d0df6b6..f7017f23337b90a2b2ceb65a4e1050e8ad89e065 https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Utility-Libraries/+log/c9ca4ac620a238a93c65d864f2eaa33954d74509..89b8b0df6de86957e9b3489ccfc953d9ec52bb68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC scroggo@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: scroggo@google.com Change-Id: I27709b56856b59cf0f26e31d309833971467fda6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/767779 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
SkTypeface::MakeDefault can fallback to an empty typeface. Some of our clients depend on a non-null SkTypeface in various places, so we should make sure there is a public way to generate one, even if it has no glyphs. Example potential use: https://crrev.com/c/4969595 Change-Id: I4275842850f7192eed830ad7eda326ac634cec6c Bug: b/305780908 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/771183 Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
Breaking Flutter (who uses our BUILD.gn files directly), as well as a few Skia tests not on the CQ Bug: b/305780908 Change-Id: I7b4b3b346edc568675c725ef6eb44d8578b2ffb5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/771703 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
The intersect code is going to dereference fTop and fBottom of both the left and right. It is a logical error if they don't exist. Guard against that. Bug: oss-fuzz:61271 Change-Id: I624e70f9b6b47270a03754061021dc8ce80b922a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/771705 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Herb Derby <herb@google.com>
Change-Id: I76c72f54c24bed60cd5e5b3693e9a65b9065f41f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/772316 Auto-Submit: Greg Daniel <egdaniel@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
https://chromium.googlesource.com/vulkan-deps.git/+log/1a99a795c229..e334b7a22bdd Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Tools/+log/ff450810971cf99b6cd04944c314c26e66930997..2d956672d73321bfb22b378c06033f0bd885d61c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-skia-autoroll Please CC herb@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE Bug: None Tbr: herb@google.com Change-Id: I916c8bc54f60e7af077003474215a1ca6292d838 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/772291 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
https://skia.googlesource.com/skcms.git/+log/fa50717f8c06..c01d0bc50536 2023-10-30 johnstiles@google.com Implement basic RGB op fusing in skcms. 2023-10-30 johnstiles@google.com Factor out curve-op selection code. 2023-10-30 eustas@google.com Further harden exp2f_ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skcms-skia-autoroll Please CC brianosman@google.com,herb@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: skia/skia.primary:Canary-Chromium Tbr: brianosman@google.com,herb@google.com Change-Id: I572ba1e60077d7a5a4f237b164b84dd7ddd6b5a5 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/772283 Bot-Commit: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: skia-autoroll <skia-autoroll@skia-public.iam.gserviceaccount.com>
- tiny code-size, since it reuses the drawing code - filtering may not be as fine-tuned as the HQ downsampler This downsampler is not enabled by default (since it slightly changes gms) but is checked in so it can be experimented with. Might consider using build or runtime flags to switch between this and HQ while we figure out which clients want which one. Bug: b/307987911 Change-Id: I40e370a9b338f0668366a3feb2ebb14c1849c209 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/771699 Commit-Queue: Mike Reed <mike@reedtribe.org> Auto-Submit: Mike Reed <mike@reedtribe.org> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@google.com>
Change-Id: I291b73b9ab2e4766c2633f2708b398474e37a99c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/772439 Reviewed-by: Heather Miller <hcm@google.com>
Change-Id: Ia419f9327cd52a28b5509c98c0537b19cbfc7bc4 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/772472 Reviewed-by: Heather Miller <hcm@google.com>
The low-res blurred image was rendered into the rounded-out coords, and any decal-tiling should occur beyond their boundaries. By using the original scaled coords as the subset boundary, we'd introduce transparency at the edge when re-expanding. Previously this was never visible because of quirks in how SkBlurImageFilter requested its output (always padded with the blur radius, even if it were to then be cropped). While the changes to the subsetting logic accounted for 90% of the visible seams when testing in chrome (and all the visible seams when running in viewer), it was also necessary for the downscaled blur to write one extra pixel of padding that could be sampled from when doing the re-expand. Bug: chromium:1500021 Change-Id: I18c147270db7b42568f4e7034b13c2dc4ab19e4a Reviewed-on: https://skia-review.googlesource.com/c/skia/+/775517 Reviewed-by: Robert Phillips <robertphillips@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com> (cherry picked from commit e585bb6) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/776156 Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: Michael Ludwig <michaelludwig@google.com> Reviewed-by: John Stiles <johnstiles@google.com> (cherry picked from commit 96270e0) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/776957 Commit-Queue: Robert Phillips <robertphillips@google.com>
Color text glyphs can be stored across multiple atlas textures, which requires sampling from one or another texture. However, if we use multiple appendTextureLookup calls with the same colorspace transform helper, it ends up generating multiple copies of its helper functions. Instead, we will pick our texture, sample its value, and apply the colorspace transform to the result outside the if-then-else block. Bug: b/309422936 Bug: chromium:1499098 Change-Id: I468fe3ef323081b22537427f1f7a894e8a52073c Reviewed-on: https://skia-review.googlesource.com/c/skia/+/775397 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com> (cherry picked from commit f91d393) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/779337
Bug: chromium:1505053 Change-Id: I42f2ff872bbf054686ec7af0cc85ff63055fcfbf Reviewed-on: https://skia-review.googlesource.com/c/skia/+/782936 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by: Michael Ludwig <michaelludwig@google.com> Auto-Submit: John Stiles <johnstiles@google.com> (cherry picked from commit 6169a1f) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/782577 Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com>
The Flutter roll was failing due to -Wsign-compare. Bug: chromium:1505053 Change-Id: Id12876f6f97682466f19b56cfa562366380f27cb Reviewed-on: https://skia-review.googlesource.com/c/skia/+/783036 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com> (cherry picked from commit 0eea0b2) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/783297 Reviewed-by: John Stiles <johnstiles@google.com> Commit-Queue: John Stiles <johnstiles@google.com> Auto-Submit: Brian Osman <brianosman@google.com>
Change-Id: I70ba2400ca607f70fe7d3daadef40d131dbc9b32 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/827560 Reviewed-by: Heather Miller <hcm@google.com>
M120 merge issues: Conflicting includes Bug: b/360758697 No-Try: true No-Presubmit: true No-Tree-Checks: true Change-Id: I46eb92ac6ed71646fb05a910f8d577ec851e3b3f Reviewed-on: https://skia-review.googlesource.com/c/skia/+/891636 Commit-Queue: James Godfrey-Kittle <jamesgk@google.com> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/894936 Reviewed-by: James Godfrey-Kittle <jamesgk@google.com>
The callers of PatternHelper which are not updated here pass in a TArray size as repeatCount, which already prevents overflow: https://crsrc.org/c/third_party/skia/include/private/base/SkTArray.h?q=kMaxCapacity Bug: b/361461526 Change-Id: I86c494cb00223f0bb8d68540d33d7230b60c9486 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/893916 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: James Godfrey-Kittle <jamesgk@google.com> (cherry picked from commit 07fcb9a) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/898036 Reviewed-by: James Godfrey-Kittle <jamesgk@google.com>
Check total index count in onCombineIfPossible. Bug: b/360265320 Change-Id: I02f04593b60dcd2470580110d0a555ed4bf47280 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/890322 Commit-Queue: Michael Ludwig <michaelludwig@google.com> (cherry picked from commit fdc8c2d) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/894465 Reviewed-by: Michael Ludwig <michaelludwig@google.com>
…aces Bug: 355465305 Change-Id: Ifb87db5e8d0d0c29449e6a3e82254189e3f2d33b Reviewed-on: https://skia-review.googlesource.com/c/skia/+/886696 Commit-Queue: Brian Osman <brianosman@google.com> (cherry picked from commit 05097fb) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/892616 Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Bug: 355465305 Change-Id: Ife25289f7b3489701c67b7dc5d30e473019a1193 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/888376 Commit-Queue: Brian Osman <brianosman@google.com> (cherry picked from commit d1b243b) Reviewed-on: https://skia-review.googlesource.com/c/skia/+/892676 Reviewed-by: Michael Ludwig <michaelludwig@google.com>
…cation size" This reverts commit a59291e. Reason for revert: unit test uses code not in m120. Original change's description: > [M120-LTS][SkSL:RP] Prevent overflow when computing slot allocation size > > Bug: 355465305 > Change-Id: Ife25289f7b3489701c67b7dc5d30e473019a1193 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/888376 > Commit-Queue: Brian Osman <brianosman@google.com> > (cherry picked from commit d1b243b) > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/892676 > Reviewed-by: Michael Ludwig <michaelludwig@google.com> Bug: 355465305 Change-Id: I27fe9fa6d769c84955bbbc2ca01c10305d4349b2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/c/skia/+/899717 Auto-Submit: Michael Ludwig <michaelludwig@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
…cation size" This reverts commit 7ba220b. Reason for revert: removing unit test that fails to compile in m120 since all that's needed is the actual SkSL::RP updates for the LTS chrome release. Original change's description: > Revert "[M120-LTS][SkSL:RP] Prevent overflow when computing slot allocation size" > > This reverts commit a59291e. > > Reason for revert: unit test uses code not in m120. > > Original change's description: > > [M120-LTS][SkSL:RP] Prevent overflow when computing slot allocation size > > > > Bug: 355465305 > > Change-Id: Ife25289f7b3489701c67b7dc5d30e473019a1193 > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/888376 > > Commit-Queue: Brian Osman <brianosman@google.com> > > (cherry picked from commit d1b243b) > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/892676 > > Reviewed-by: Michael Ludwig <michaelludwig@google.com> > > Bug: 355465305 > Change-Id: I27fe9fa6d769c84955bbbc2ca01c10305d4349b2 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/899717 > Auto-Submit: Michael Ludwig <michaelludwig@google.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bug: 355465305 Change-Id: Iea2884487313206150f98becbbf22a5a286ff512 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/901140 Reviewed-by: Robert Phillips <robertphillips@google.com>
Merge upstream Skia milestone 120 (chrome/m120) into the SkiaSharp fork. Breaking changes resolved: - GrDirectContext::MakeGL() removed → updated to GrDirectContexts::MakeGL() - GrDirectContext::MakeVulkan() deprecated → proactively updated to GrDirectContexts::MakeVulkan() - Added #include for new GrGLDirectContext.h and GrVkDirectContext.h headers - Removed orphaned SkTypeface::UniqueID() implementation (upstream removed declaration) - Kept fork's custom SkTypeface::RefDefault() and SkFontMgr::MakeDefault() - DEPS: preserved fork's custom dependency pins (libwebp, brotli, expat, libpng, zlib, freetype, harfbuzz, vulkanmemoryallocator) - DEPS: updated non-customized deps to m120 (libjpeg-turbo, spirv-cross, vulkan-headers) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Mar 25, 2026
- Update externals/skia submodule to dev/update-skia-m120 (m120 merge) - Regenerate SkiaApi.generated.cs (adds sk_surface_draw_with_sampling) - Update VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0 - Update cgmanifest.json: chrome_milestone 120, new commit hash - Update SKILL.md: use Opus model for validation agent Native build: ✅ (macOS ARM64) C# build: ✅ (0 errors) Tests: ✅ (5374 total, 0 failed, 25 hardware skips) Companion PR: mono/skia#173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Mar 25, 2026
- Update externals/skia submodule to dev/update-skia-m120 (m120 merge) - Regenerate SkiaApi.generated.cs (adds sk_surface_draw_with_sampling) - Update VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0 - Update cgmanifest.json: chrome_milestone 120, new commit hash - Update SKILL.md: use Opus model for validation agent Native build: ✅ (macOS ARM64) C# build: ✅ (0 errors) Tests: ✅ (5374 total, 0 failed, 25 hardware skips) Companion PR: mono/skia#173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Mar 25, 2026
- Update externals/skia submodule to dev/update-skia-m120 (m120 merge) - Regenerate SkiaApi.generated.cs (adds sk_surface_draw_with_sampling) - Update VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0 - Update cgmanifest.json: chrome_milestone 120, new commit hash - Update SKILL.md: use Opus model for validation agent Native build: ✅ (macOS ARM64) C# build: ✅ (0 errors) Tests: ✅ (5374 total, 0 failed, 25 hardware skips) Companion PR: mono/skia#173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mattleibow
added a commit
to mono/SkiaSharp
that referenced
this pull request
Mar 25, 2026
- Update externals/skia submodule to dev/update-skia-m120 (m120 merge) - Regenerate SkiaApi.generated.cs (adds sk_surface_draw_with_sampling) - Update VERSIONS.txt: milestone 120, soname 120.0.0, assembly 3.120.0.0 - Update cgmanifest.json: chrome_milestone 120, new commit hash - Update SKILL.md: use Opus model for validation agent Native build: ✅ (macOS ARM64) C# build: ✅ (0 errors) Tests: ✅ (5374 total, 0 failed, 25 hardware skips) Companion PR: mono/skia#173 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
🤖 Automated diff report for this Skia bump ( This is a generated summary of fork patch changes, dependency updates, generated binding checks, and companion PR findings — not a code review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Skia to Milestone 120
Merges upstream
chrome/m120into the SkiaSharp fork.Breaking changes resolved
GrDirectContext::MakeGL()removed → updated toGrDirectContexts::MakeGL()from newGrGLDirectContext.hGrDirectContext::MakeVulkan()deprecated → proactively updated toGrDirectContexts::MakeVulkan()from newGrVkDirectContext.hSkTypeface::UniqueID()implementation (upstream removed declaration)SkTypeface::RefDefault()andSkFontMgr::MakeDefault()DEPS
Merge conflicts resolved
DEPS: kept fork structure + custom pinssrc/core/SkTypeface.cpp: keptRefDefault(), added upstreamMakeEmpty()src/gpu/ganesh/ops/DrawMeshOp.cpp: accepted upstream overflow fixRELEASE_NOTES.md,infra/bots/jobs.json: accepted upstreamCompanion PR