resync #1
Open
resync #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This commit](2503464) changed the way we detect the context for fetching the `let_it_be` defined variables, matching only the `before(:context)`. Those variables should be accessible by both before/after, so this adds back the generic `:context` matcher to support all hooks.
…or minitest. When the test suite is run in parallel, the run method only enqueues the test jobs and returns right after that, so we mustn't roll back the transaction at that point. Instead, intercept the Minitest.run_one_method call that actually runs a test case. In each process, we will keep track of when the last test case of a test file has run, and roll back the transaction in that moment. This works because test cases from different test files are added to the queue and processed in order, i.e. once we see a test case from a different class/test file, no test cases from the previous test file will be run anymore.
parallelize_teardown allows registering callbacks that are run after parallel test execution. It is called after all tests are run and before the forked processes are closed, so we can use it to clean up the last of the before_all transactions.
All recent versions of JRuby support unicode identifiers.
* Respect the printer on the configure block It was being cached and ignoring the one defined the configuration * Update CHANGELOG * Fix rubocop warnings * Satisfy rubocop * Update CHANGELOG.md Co-authored-by: Guillermo Siliceo <guillermo.siliceo@gmail.com> Co-authored-by: Vladimir Dementyev <dementiev.vm@gmail.com>
* restore the lock_thread value after rollback * use :@lock_thread instead of "@lock_thread" * avoid instance variable collisions with cats * add a changelog entry Co-authored-by: Vladimir Dementyev <dementiev.vm@gmail.com>
This is to ensure that if tests were run in parallel, that values would not override each other/be used from other threads.
To make older Rails work correctly
This seems to have been added last year in vernier's readme: jhawthorn/vernier@70d463c It's an instance of the firefox profiler fork, which means it's much more suitable for ruby. In my limited testing, only the fork was able to show source.
Make sure we only subscribe once and unsubscribe once we've rolled back all before_all transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.