support special URL paths such as .well-known.#708
support special URL paths such as .well-known.#708hansbak wants to merge 1 commit intomoqui:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the XML Screen XSD to allow transition names that support special URL paths (eg .well-known) by expanding the allowed character pattern for the transition/@name attribute.
Changes:
- Updated
transition/@namedocumentation to mention leading-dot path support (eg.well-known). - Added an inline XSD pattern restriction intended to allow
.and-in transition names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <xs:simpleType> | ||
| <xs:restriction base="xs:token"> | ||
| <xs:pattern value="[\-\.a-zA-Z][\-_\.a-zA-Z0-9]*" /> | ||
| </xs:restriction> | ||
| </xs:simpleType> |
There was a problem hiding this comment.
This inline xs:simpleType makes the schema invalid because the attribute already declares type="name-package" (XSD attributes cannot have both type and an anonymous simpleType). Consider defining a dedicated named simpleType (eg for transition path names) and referencing it from the name attribute (and other places that accept transition names), or remove the type attribute and derive the restriction from name-package/xs:string instead.
|
|
||
| The transition name is used in link and other elements in place of URLs when going to another | ||
| screen within this application. The transition name will appear briefly as the URL before the | ||
| redirect is done for the transition response. | ||
| </xs:documentation></xs:annotation> | ||
| redirect is done for the transition response. A name may also start with a | ||
| dot to support special URL paths such as .well-known. </xs:documentation> |
There was a problem hiding this comment.
The documentation in this block still emphasizes camelCase/lower-case naming, but the change is introducing support for leading-dot URL paths (eg .well-known) and the new pattern also broadens allowed characters. Please adjust the wording to accurately describe the allowed formats/exceptions so it matches the schema validation.
There was a problem hiding this comment.
not sure what need to changed? already describing with the .well-known. example?
No description provided.