Foundry v1.4#95
Merged
Merged
Conversation
QGarchery
commented
Oct 23, 2025
peyha
previously approved these changes
Oct 23, 2025
MathisGD
previously approved these changes
Oct 28, 2025
peyha
previously approved these changes
Oct 28, 2025
adhusson
previously approved these changes
Oct 28, 2025
MathisGD
previously approved these changes
Oct 28, 2025
adhusson
previously approved these changes
Dec 17, 2025
peyha
previously approved these changes
Dec 18, 2025
peyha
left a comment
peyha
left a comment
Collaborator
There was a problem hiding this comment.
did not check the certora part
MathisGD
previously approved these changes
Dec 18, 2025
…ra/fix-consistent-instantiation
…iation [Certora] Fix consistent instantiation
[Certora] Safe approve summary
MathisGD
approved these changes
Apr 23, 2026
peyha
reviewed
Apr 23, 2026
| - Immutability | ||
| - MarketExists | ||
| - Liveness | ||
| - MarketExists |
Collaborator
There was a problem hiding this comment.
is the order important or you're just sorting alphabetically ?
Contributor
Author
There was a problem hiding this comment.
not important, just sorting alphabetically (easier to check if one is missing)
peyha
approved these changes
Apr 23, 2026
peyha
left a comment
peyha
left a comment
Collaborator
There was a problem hiding this comment.
did not check the certora
adhusson
reviewed
May 1, 2026
Comment on lines
+8
to
+9
| // To fix an issue where the approve call is unresolved in the constructor. | ||
| function _.safeApprove(address, address, uint256) internal => NONDET; |
Contributor
There was a problem hiding this comment.
this is related to the new foundry? (also it's unsound?)
Contributor
There was a problem hiding this comment.
This PR also fixed the certora CI (newer certora broke it)
Indeed, not sound (but probably fine)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updates to latest Certora prover, and adds commit SHA for actions