Fix a flaky test by cleaning a polluted state#15
Open
sturmianseq wants to merge 1 commit intomortele:masterfrom
Open
Fix a flaky test by cleaning a polluted state#15sturmianseq wants to merge 1 commit intomortele:masterfrom
sturmianseq wants to merge 1 commit intomortele:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 2328 2329 +1
=========================================
+ Hits 2328 2329 +1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR is to fix a flaky test
test/test_occam_data.py::test_occam_data_not_save_to_npy, which can fail after runningtest/test_occam_data.py::test_occam_data_attributes, but passes when it is run in isolation.Reproduce the test failure
Run the following command:
Expected result
test/test_occam_data.py::test_occam_data_not_save_to_npyshould pass after runningtest/test_occam_data.py::test_occam_data_attributes.Actual result
Why it fails
The test class directory is not deleted after running
test/test_occam_data.py::test_occam_data_attributes, which leads to a pollution.Fix
Delete
class_dirat the end oftest/test_occam_data.py::test_occam_data_attributes