update layerRect() to handle inconsistent leading and spaceBefore/spaceAfter paragraph props#11
Open
fartinmartin wants to merge 1 commit intomotiondeveloper:masterfrom
Open
update layerRect() to handle inconsistent leading and spaceBefore/spaceAfter paragraph props#11fartinmartin wants to merge 1 commit intomotiondeveloper:masterfrom
layerRect() to handle inconsistent leading and spaceBefore/spaceAfter paragraph props#11fartinmartin wants to merge 1 commit intomotiondeveloper:masterfrom
Conversation
…` + `spaceBefore`/`spaceAfter` paragraph props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
layerRect()will calculatelineGapbased onsourceText.style.leadingand multiply by number of lines:aefunctions/src/index.ts
Lines 300 to 307 in a6a7771
But, if a text layer has per-character styles applied (via UI, or via expressions from something like
style-parser) we'd need to calculatelineGapbased on the styles at each line's starting character index value.This PR introduces a new option
consistentLeadingthat when set tofalsewill calculate as described. (Open to a better option name/API here, haha!)Additionally, the
spaceBeforeandspaceAfterparagraph props can affect the height of a given text layer. This PR adds the appropriate height given said paragraph spacing as well.Here's an example project to check out: aefunctions-layerRect.zip
Note: In this PR, I no longer use
textCount()to determinenumLines. I found the regexp in this PR to be more consistent/expected—let me know if it breaks an edge case I haven't considered!