fix compile with local octomap#267
Open
mosfet80 wants to merge 1 commit into
Open
Conversation
rhaschke
reviewed
Jan 22, 2026
| target_include_directories(${PROJECT_NAME} | ||
| PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| $<INSTALL_INTERFACE:include/${PROJECT_NAME}>) | ||
| $<INSTALL_INTERFACE:include/${PROJECT_NAME}> ${OCTOMAP_INCLUDE_DIRS}) |
Contributor
There was a problem hiding this comment.
OCTOMAP_INCLUDE_DIRS should be declared as SYSTEM includes. Do they need to be PUBLIC?
Better add them in line 109.
Contributor
There was a problem hiding this comment.
You didn't comment on that yet or changed the config.
mosfet80
force-pushed
the
fixCompile
branch
2 times, most recently
from
d17a8f6 to
990c180
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ros2 #267 +/- ##
=======================================
Coverage 69.04% 69.04%
=======================================
Files 21 21
Lines 3368 3368
Branches 325 325
=======================================
Hits 2325 2325
Misses 932 932
Partials 111 111 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhaschke
reviewed
Jan 27, 2026
Contributor
rhaschke
left a comment
rhaschke
left a comment
There was a problem hiding this comment.
Why did you remove the includes? They are still needed, aren't they?
Does octomap provide targets as well? If so, it would be much better to use those.
fix /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::addValue(float const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::OcTreeNode()' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to `: undefined reference to `octomap::Pointcloud::Pointcloud()octomap::Pointcloud::Pointcloud()' ' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::~OcTreeNode()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::addValue(float const&)' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to `: undefined reference to `octomap::Pointcloud::~Pointcloud()octomap::Pointcloud::~Pointcloud()' ' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::transform(octomath::Pose6D)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::OcTreeNode()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::~Pose6D()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::addValue(float const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::OcTreeNode::addValue(float const&)' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to `: undefined reference to `octomap::OcTreeNode::~OcTreeNode()octomap::OcTree::OcTree(double)' ' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomath::Pose6D::inv() const' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to `octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7/usr/bin/ld/usr/bin/ld: : undefined reference to `: /usr/local/lib64/libfcl.so.0.7octomap::Pointcloud::transform(octomath::Pose6D)/usr/local/lib64/libfcl.so.0.7: undefined reference to `'
rhaschke
reviewed
Apr 23, 2026
| # Enforce the system package version on Ubuntu jammy and noble which is also used by libfcl-dev | ||
| # The version is fixed to prevent ABI conflicts with ros-octomap | ||
| find_package(octomap 1.9.7...<1.10.0 REQUIRED) | ||
| find_package(octomap 1.9.10 REQUIRED) |
Contributor
There was a problem hiding this comment.
Why do you restrict the version even further?
| target_include_directories(${PROJECT_NAME} | ||
| PUBLIC $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include> | ||
| $<INSTALL_INTERFACE:include/${PROJECT_NAME}>) | ||
| $<INSTALL_INTERFACE:include/${PROJECT_NAME}> ${OCTOMAP_INCLUDE_DIRS}) |
Contributor
There was a problem hiding this comment.
You didn't comment on that yet or changed the config.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix compile on linux fedora with local fcl and octomap
/usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to
octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::addValue(float const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::OcTreeNode()' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to: undefined reference tooctomap::Pointcloud::Pointcloud()octomap::Pointcloud::Pointcloud()' ' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::~OcTreeNode()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::addValue(float const&)' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to: undefined reference tooctomap::Pointcloud::~Pointcloud()octomap::Pointcloud::~Pointcloud()' '/usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference to
octomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::transform(octomath::Pose6D)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::OcTreeNode()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::~Pose6D()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::~Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::addValue(float const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::OcTreeNode::addValue(float const&)' /usr/bin/ld/usr/bin/ld: : /usr/local/lib64/libfcl.so.0.7/usr/local/lib64/libfcl.so.0.7: undefined reference to: undefined reference tooctomap::OcTreeNode::~OcTreeNode()octomap::OcTree::OcTree(double)' ' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::Pose6D(octomath::Pose6D const&)' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomath::Pose6D::inv() const' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7: undefined reference tooctomap::Pointcloud::Pointcloud()' /usr/bin/ld: /usr/local/lib64/libfcl.so.0.7/usr/bin/ld/usr/bin/ld: : undefined reference to: /usr/local/lib64/libfcl.so.0.7octomap::Pointcloud::transform(octomath::Pose6D)/usr/local/lib64/libfcl.so.0.7: undefined reference to'