Skip to content

Conversation

@vatanaksoytezer
Copy link
Contributor

Enables CI for Rolling and Galactic distros. Will fix ros-controls/ros2_controllers#200 from the repos file once it gets merged. The extra repos and CI files for rolling and galactic will be removed once ros2_control and ros2_controllers are released for rolling and galactic and synced (for main repos).

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #494 (75dff2a) into main (c029942) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #494      +/-   ##
==========================================
- Coverage   45.20%   45.18%   -0.02%     
==========================================
  Files         169      169              
  Lines       18729    18732       +3     
==========================================
- Hits         8465     8462       -3     
- Misses      10264    10270       +6     
Impacted Files Coverage Δ
...mpl_interface/src/model_based_planning_context.cpp 48.98% <0.00%> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 0.00% <0.00%> (ø)
...ics_plugin_loader/src/kinematics_plugin_loader.cpp 0.00% <0.00%> (ø)
...it_ros/robot_interaction/src/robot_interaction.cpp 0.00% <0.00%> (ø)
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 74.72% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c029942...75dff2a. Read the comment docs.

@vatanaksoytezer
Copy link
Contributor Author

All the CI runs should pass. The failing ones are failing because of the flaky OMPL test... Shall we disable that as well @henningkayser ? Since this is in my sprint right now, I will work on enabling them real quick

@vatanaksoytezer
Copy link
Contributor Author

See #495

@henningkayser
Copy link
Member

Please squash all your small fixup commits and do a rebase, then lgtm

@vatanaksoytezer
Copy link
Contributor Author

Please squash all your small fixup commits and do a rebase, then lgtm

Great! Done. Should be mergable if this CI passes

Vatan Aksoy Tezer and others added 3 commits June 15, 2021 13:26
@henningkayser henningkayser merged commit 1d12504 into moveit:main Jun 15, 2021
@vatanaksoytezer vatanaksoytezer mentioned this pull request Jul 14, 2021
MikeWrock pushed a commit to MikeWrock/moveit2 that referenced this pull request Aug 15, 2022
* Extend constraint manifold tutorial with definition format

This is used since moveit/moveit@2968865

* Explain how to put a constraints file together

* Provide more concrete example for launching the generator

Co-authored-by: Michael Görner <me@v4hn.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants