Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Dec 22, 2025

📜 Tickets

Bugzilla ticket

💡 Description

Updated the code to handle the upstream change from app-services: mozilla/application-services#7131

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

Updated the code to handle the upstream change from app-services:
mozilla/application-services#7131
@bendk bendk requested a review from a team as a code owner December 22, 2025 16:02
@bendk bendk requested a review from Cramsden December 22, 2025 16:02
@bendk
Copy link
Contributor Author

bendk commented Dec 22, 2025

The motivation for this is the relay integration. There they want to get a new access token when they see a 4XX error. Right now the only way is to call clearAccessTokenCache. This is an improvement since it only requires 1 function call and it only clears out the cached relay token, not other access tokens.

I'm not sure how to test this properly because it depends on the upstream change being merged, but I'd like to avoid doing that before this one is approved. However, this change is pretty trivial so we could just merge the change into app-services and resolve the breakage after the next nightly is built.

@Cramsden
Copy link
Contributor

@bendk looks like there are some build errors in the rust components!

@bendk
Copy link
Contributor Author

bendk commented Dec 30, 2025

I'm pretty sure that's just because we haven't merged the code into app-services yet. I was going to wait until after the new year, but I'm also happy to merge now if that makes things easier for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants