[RELOPS-2269] Skip people remover script when no listed users exist#1108
Open
rcurranmoz wants to merge 5 commits intomasterfrom
Open
[RELOPS-2269] Skip people remover script when no listed users exist#1108rcurranmoz wants to merge 5 commits intomasterfrom
rcurranmoz wants to merge 5 commits intomasterfrom
Conversation
Add an unless guard that checks for each user's home directory — exits 0 (skip exec) when none are present, exits 1 (run exec) if any remain. This avoids running the script on every puppet apply once cleanup is done. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rcurranmoz
changed the title
Use path + sh -c so Puppet can find the shell and execute the for builtin in the unless check without a 'not qualified' error. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
aerickson
approved these changes
Mar 25, 2026
Member
aerickson
left a comment
aerickson
left a comment
There was a problem hiding this comment.
Would be nice to have the names of users to purge in a variable. The cleanup script must have the names, maybe we should just move the logic into the remover script.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an unless guard that checks for each user's home directory — exits 0 (skip exec) when none are present, exits 1 (run exec) if any remain. This avoids running the script on every puppet apply once cleanup is done.