Skip to content

chore: version bump v4.0.2#155

Open
abhishekmadan30 wants to merge 1 commit intomozilla-releng:mainfrom
abhishekmadan30:version4.0.2
Open

chore: version bump v4.0.2#155
abhishekmadan30 wants to merge 1 commit intomozilla-releng:mainfrom
abhishekmadan30:version4.0.2

Conversation

@abhishekmadan30
Copy link
Contributor

No description provided.

CHANGELOG.md Outdated

### Feat

- Change all voluptuous schema names to LegacySchema
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 4.1.0 because you're introducing a new feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the one who advised abhishek to do a patch update.

From a user interface point of view the schema variable names are all the same here. And perf improvement was actually implemented in taskcluster-taskgraph rather than here.

So for that reason I figured this should just be treated like a dependency update.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, but this should say Fix rather than Feat then..

@abhishekmadan30 please remove the Feat section and merge this in with Fix below.

Or use cz bump and it should do the right thing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries; I didn't realize this was being worked out elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants