Conversation
de59798 to
75476e2
Compare
75476e2 to
b12d530
Compare
|
There's at least one problem with this, which is that the Github API is inconsistent with what it returns for the There may be other issues, and I also haven't tested this in any real world scenario yet. |
|
I think it's because despite the commit targetting this repo, it's actually in Julien's repo. https://api.github.com/repos/jcristau/scriptworker/commits/0123e3ddb66e0032dccf807a76915600e9f509ae/pulls vs https://api.github.com/repos/mozilla-releng/scriptworker/commits/0123e3ddb66e0032dccf807a76915600e9f509ae/pulls (first one works, second one doesn't) |
Due to the issue described in #729, this PR seeks to drop the
aiomemoizettldependency. It does this by using a documented API that supports tokens to avoid the need to memoize (because we have no fears over rate limiting). It's unclear if this API existed or not when we first added that dependency.After writing this, I realized that we may want to memoize anyways, to avoid unnecessary burning requests with our token, so we could consider doing so some other way rather than (or in addition to) switching APIs.