Remove misleading error message about docker-worker artifacts#764
Open
ahal wants to merge 2 commits intomozilla-releng:mainfrom
Open
Remove misleading error message about docker-worker artifacts#764ahal wants to merge 2 commits intomozilla-releng:mainfrom
ahal wants to merge 2 commits intomozilla-releng:mainfrom
Conversation
We're no longer using docker-worker, so this error message is misleading. Update it with actual useful advice.
ahal
force-pushed
the
ahal/push-nxqwovtprvvs
branch
from
5794598 to
d22b047
Compare
Eijebong
reviewed
Feb 2, 2026
Comment on lines
+733
to
+734
| "path {path} not in {link_name} {task_id} chain of trust artifacts! Verify {path} " | ||
| "is correct, was produced by task {task_id}, and is listed in {cot_url}".format( |
Contributor
There was a problem hiding this comment.
I personally really liked the this is likely a bug in {task_id} part because every single time I've had CoT to debug, it was. The new message feels like a downgrade as it doesn't point to task_id as much.
Suggested change
| "path {path} not in {link_name} {task_id} chain of trust artifacts! Verify {path} " | |
| "is correct, was produced by task {task_id}, and is listed in {cot_url}".format( | |
| "path {path} not in {link_name} {task_id} chain of trust artifacts! " | |
| "This is likely a bug in {task_id}. Verify that {path} was produced by " | |
| "the task and is listed in {cot_url}".format( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.