Examine "jp/unit tests" branch

[gene1wood]

• Take a look at this branch
• Figure out what it does
• Decide if we want to use this
• Merge it or make an issue capturing the idea or close and delete the branch

[gene1wood]

@nnja Would you like to see if there's any unit test content here worth keeping?

[nnja]

@gene1wood Sure. I'll take a look today or tomorrow.

[jpaugh]

So, I didn't have a very good story for testing agithub. If it were me, I'd rethink this, and restart from scratch. These tests don't mock up the GitHub API (which they probably should). They require connecting to the real API, and thus require entering real credentials for any non-public API usage.

[gene1wood]

@nnja based on @jpaugh's comment it sounds like we should remove unit tests and pursue some of the ideas you and I'd chatted about for starting from scratch on them with a good API mocking solution.

Maybe after the move from httplib to requests.

[nnja]

@gene1wood @jpaugh Any chance either of you are at the PyCon 2018 sprints? I was thinking about working on this on Wednesday or for a half day on Thursday.

[gene1wood]

@nnja I'm not unfortunately. If you want to call out a day and time to meet online I could video chat.

[nnja]

@gene1wood Any chance you're available between 10am and 12pm EST tomorrow?

[gene1wood]

@nnja Yes, ping me on keybase and we can coordinate a call.