Bug 2004779 - Avoid parsing JSON for the packaged data if it's outdated, by storing the timestamp in a separate file #7121
+66
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
store-packaged-timestamp-separately
branch
3 times, most recently
from
165b764 to
9c07c36
Compare
Contributor
Author
|
This is now ready for review. |
…ed, by storing the timestamp in a separate file.
mstange
force-pushed
the
store-packaged-timestamp-separately
branch
from
9c07c36 to
7b3119c
Compare
gruberb
approved these changes
Dec 16, 2025
| .and_then(|data| serde_json::from_str(data).ok()) | ||
| let str_data = Self::get_packaged_data(&self.collection_name)?; | ||
| let data: CollectionData = serde_json::from_str(str_data).ok()?; | ||
| debug_assert_eq!(data.timestamp, self.load_packaged_timestamp().unwrap()); |
Member
There was a problem hiding this comment.
Nice use of debug_assert_eq! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization. It does not affect the API, does not change behavior, and does not add dependencies.
https://bugzilla.mozilla.org/show_bug.cgi?id=2004779