Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Dec 10, 2025

Instead we do some parsing of the Cargo.toml files ourselves. I ran cargo uniffi-bindgen generate -l kotlin --library ~/application-services/target/debug/libmegazord.so with both the old and new version and the contents were identical.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk requested a review from mhammond December 10, 2025 17:17
@bendk bendk force-pushed the push-pylsxtrnuluv branch from 5753a4d to 6c1b8fb Compare December 10, 2025 17:18
Instead we do some parsing of the `Cargo.toml` files ourselves.  I ran
`cargo uniffi-bindgen generate -l kotlin --library ~/application-services/target/debug/libmegazord.so` 
with both the old and new version and the contents were identical.
@bendk bendk force-pushed the push-pylsxtrnuluv branch from 6c1b8fb to 22ce06c Compare December 10, 2025 17:30
Copy link
Member

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks! I agree we should try and upstream this into uniffi itself, I guess behind another feature?

@mhammond mhammond added this pull request to the merge queue Dec 11, 2025
Merged via the queue into mozilla:main with commit 4673a6b Dec 11, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants