WIP: Bug 2003370 - Use and react to Gecko preferences stored values #7134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohall-m
changed the title
ohall-m
changed the title
This patch begins storing a `PreviousState` on `ExperimentEnrollment` when it is of type `EnrollmentStatus::Enrolled`. It also introduces `PreviousState::GeckoPref` to hold Gecko original preference values for Gecko pref based experiments. The public APIs it opens are `registerPreviousGeckoPrefStates` and `getPreviousState`.
ohall-m
changed the title
This patch adds functionality to use the new GeckoPref's PreviousState.
It adds:
* `set_gecko_prefs_original_values` for external handling of setting prefs back to original values
* Mechanisms to return to a previous states when:
* `on_experiment_updated`
* Certain situations and as determined in `will_pref_experiment_change`
* `on_experiment_ended`
* `on_opt_out`
Author
|
Moved to #7135 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds functionality to use the new GeckoPref's PreviousState.
It adds:
set_gecko_prefs_original_valuesfor external handling of setting prefs back to original valueson_experiment_updatedwill_pref_experiment_changeon_experiment_endedon_opt_outCurrent WIP based on: 40275a1 December, 19 2025 #7122.
Pull Request checklist
[ci full]to the PR title.