Skip to content

Remove light-theme footer from WhatsNew pages #14463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reemhamz merged 2 commits into from
Apr 19, 2024
Merged

Remove light-theme footer from WhatsNew pages #14463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc64a56
removed light footer from wnp
reemhamz Apr 16, 2024
d89dfcf
removed black icons and updatd icon paths to be Protocol icons
reemhamz Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions bedrock/firefox/templates/firefox/whatsnew/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,13 @@
{% block stub_attribution %}{% endblock %}

{% block content %}
<main class="content-wrapper mzp-t-firefox">
{% block wnp_header %}
{% include 'firefox/whatsnew/includes/header.html' %}
{% endblock %}
<main class="content-wrapper mzp-t-firefox">
{% block wnp_header %}
{% include 'firefox/whatsnew/includes/header.html' %}
{% endblock %}

{% block wnp_content %}{% endblock %}
{% block wnp_content %}{% endblock %}

{% include 'firefox/whatsnew/includes/release-notes.html' %}
</main>

{% endblock %}

{% block site_footer %}
{% with theme_class='mzp-t-light' %}
{% include 'includes/protocol/footer/footer.html' %}
{% endwith %}
{% include 'firefox/whatsnew/includes/release-notes.html' %}
</main>
{% endblock %}
32 changes: 9 additions & 23 deletions media/css/firefox/switch.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,41 +120,27 @@ $image-path: '/media/protocol/img';
position: relative;

&::before {
@include bidi(((left, 0, right, auto),));
background-image: url('/media/img/logos/social/social-icon-sprite-dark.svg');
background-size: 24px auto;
background-repeat: no-repeat;
content: '';
display: inline-block;
height: 22px;
width: 24px;
vertical-align: bottom;
background-size: cover;
position: absolute;
bottom: 0;
content: '';
top: 0;
left: 0;
height: 20px;
width: 20px;
}

&.twitter::before {
background-size: 27px auto;
background-position: 0 3px;
background-image: url('#{$image-path}/icons/social/x/black.svg');
}

&.facebook {
&::before {
background-position: 4px -81px;
}

@media #{$mq-md} {
@include bidi(((padding-left, 18px + $spacing-sm, padding-right, 0),));

&::before {
background-position: 0 -81px;
width: 18px;
}
background-image: url('#{$image-path}/icons/social/facebook/black.svg');
}
}

&.email::before {
background-position: 0 -109px;
background-image: url('#{$image-path}/icons/mail.svg');
}
}

Expand Down
62 changes: 0 additions & 62 deletions media/css/firefox/welcome11.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,66 +134,4 @@ $image-path: '/media/protocol/img';
.c-utilities {
@include white-links;
}

.mzp-c-footer.mzp-t-light {
@include white-links;
background: $color-dark-gray-60;
color: $color-white;

.mzp-c-footer-sections {
border-color: $color-dark-gray-30;

a:hover,
a:focus,
a:active {
text-decoration: underline;
}
}

.mzp-c-footer-links-social li {
a.twitter {
background-image: url('/media/protocol/img/icons/social/x/white.svg');
}

a.instagram {
background-image: url('/media/protocol/img/icons/social/instagram/white.svg');
}

a.mastodon {
background-image: url('/media/img/logos/social/mastodon-white.svg');
}

a.youtube {
background-image: url('/media/protocol/img/icons/social/youtube/white.svg');
}

// bedrock override until icons are added to protocol-assets
// https://github.com/mozilla/protocol-assets/issues/84
a.linkedin {
background-image: url('/media/img/logos/social/linkedin-white.svg');
}

a.tiktok {
background-image: url('/media/img/logos/social/tiktok-white.svg');
}

a.spotify {
background-image: url('/media/img/logos/social/spotify-white.svg');
}

a:hover,
a:focus,
a:active {
outline-color: $color-white;
}
}

.mzp-c-footer-primary-logo a {
background-image: url('/media/protocol/img/logos/mozilla/logo-word-hor-white.svg');
}

.mzp-c-footer-heading.is-summary button::before {
background: $url-image-expand-white top left no-repeat;
}
}
}
62 changes: 0 additions & 62 deletions media/css/firefox/welcome12.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,66 +165,4 @@ $image-path: '/media/protocol/img';
.c-utilities {
@include white-links;
}

.mzp-c-footer.mzp-t-light {
@include white-links;
background: $color-dark-gray-60;
color: $color-white;

.mzp-c-footer-sections {
border-color: $color-dark-gray-30;

a:hover,
a:focus,
a:active {
text-decoration: underline;
}
}

.mzp-c-footer-links-social li {
a.twitter {
background-image: url('/media/protocol/img/icons/social/x/white.svg');
}

a.instagram {
background-image: url('/media/protocol/img/icons/social/instagram/white.svg');
}

a.mastodon {
background-image: url('/media/img/logos/social/mastodon-white.svg');
}

a.youtube {
background-image: url('/media/protocol/img/icons/social/youtube/white.svg');
}

// bedrock override until icons are added to protocol-assets
// https://github.com/mozilla/protocol-assets/issues/84
a.linkedin {
background-image: url('/media/img/logos/social/linkedin-white.svg');
}

a.tiktok {
background-image: url('/media/img/logos/social/tiktok-white.svg');
}

a.spotify {
background-image: url('/media/img/logos/social/spotify-white.svg');
}

a:hover,
a:focus,
a:active {
outline-color: $color-white;
}
}

.mzp-c-footer-primary-logo a {
background-image: url('/media/protocol/img/logos/mozilla/logo-word-hor-white.svg');
}

.mzp-c-footer-heading.is-summary button::before {
background: $url-image-expand-white top left no-repeat;
}
}
}
62 changes: 0 additions & 62 deletions media/css/firefox/welcome13.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,66 +165,4 @@ $image-path: '/media/protocol/img';
.c-utilities {
@include white-links;
}

.mzp-c-footer.mzp-t-light {
@include white-links;
background: $color-dark-gray-60;
color: $color-white;

.mzp-c-footer-sections {
border-color: $color-dark-gray-30;

a:hover,
a:focus,
a:active {
text-decoration: underline;
}
}

.mzp-c-footer-links-social li {
a.twitter {
background-image: url('/media/protocol/img/icons/social/x/white.svg');
}

a.instagram {
background-image: url('/media/protocol/img/icons/social/instagram/white.svg');
}

a.mastodon {
background-image: url('/media/img/logos/social/mastodon-white.svg');
}

a.youtube {
background-image: url('/media/protocol/img/icons/social/youtube/white.svg');
}

// bedrock override until icons are added to protocol-assets
// https://github.com/mozilla/protocol-assets/issues/84
a.linkedin {
background-image: url('/media/img/logos/social/linkedin-white.svg');
}

a.tiktok {
background-image: url('/media/img/logos/social/tiktok-white.svg');
}

a.spotify {
background-image: url('/media/img/logos/social/spotify-white.svg');
}

a:hover,
a:focus,
a:active {
outline-color: $color-white;
}
}

.mzp-c-footer-primary-logo a {
background-image: url('/media/protocol/img/logos/mozilla/logo-word-hor-white.svg');
}

.mzp-c-footer-heading.is-summary button::before {
background: $url-image-expand-white top left no-repeat;
}
}
}
62 changes: 0 additions & 62 deletions media/css/firefox/welcome15.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,66 +107,4 @@ $image-path: '/media/protocol/img';
.c-utilities {
@include white-links;
}

.mzp-c-footer.mzp-t-light {
@include white-links;
background: $color-dark-gray-60;
color: $color-white;

.mzp-c-footer-sections {
border-color: $color-dark-gray-30;

a:hover,
a:focus,
a:active {
text-decoration: underline;
}
}

.mzp-c-footer-links-social li {
a.twitter {
background-image: url('/media/protocol/img/icons/social/x/white.svg');
}

a.mastodon {
background-image: url('/media/img/logos/social/mastodon-white.svg');
}

a.instagram {
background-image: url('/media/protocol/img/icons/social/instagram/white.svg');
}

a.youtube {
background-image: url('/media/protocol/img/icons/social/youtube/white.svg');
}

// bedrock override until icons are added to protocol-assets
// https://github.com/mozilla/protocol-assets/issues/84
a.linkedin {
background-image: url('/media/img/logos/social/linkedin-white.svg');
}

a.tiktok {
background-image: url('/media/img/logos/social/tiktok-white.svg');
}

a.spotify {
background-image: url('/media/img/logos/social/spotify-white.svg');
}

a:hover,
a:focus,
a:active {
outline-color: $color-white;
}
}

.mzp-c-footer-primary-logo a {
background-image: url('/media/protocol/img/logos/mozilla/logo-word-hor-white.svg');
}

.mzp-c-footer-heading.is-summary button::before {
background: $url-image-expand-white top left no-repeat;
}
}
}
Loading