Add configs and parser for scalar adjustments#235
Draft
m-d-bowerman wants to merge 32 commits intomainfrom
Draft
Add configs and parser for scalar adjustments#235m-d-bowerman wants to merge 32 commits intomainfrom
m-d-bowerman wants to merge 32 commits intomainfrom
Conversation
jaredsnyder
reviewed
Jul 11, 2024
jobs/kpi-forecasting/kpi_forecasting/configs/model_inputs/__init__.py
Outdated
Show resolved
Hide resolved
jaredsnyder
reviewed
Jul 11, 2024
jobs/kpi-forecasting/kpi_forecasting/configs/model_inputs/__init__.py
Outdated
Show resolved
Hide resolved
jaredsnyder
reviewed
Jul 15, 2024
Comment on lines
+117
to
+124
| matched_adjustment = None | ||
| for parsed_adjustment in sorted_parsed_named_adjustments: | ||
| if forecast_start_date >= parsed_adjustment.forecast_start_date: | ||
| matched_adjustment = parsed_adjustment | ||
| else: | ||
| break | ||
|
|
||
| if matched_adjustment: |
Contributor
There was a problem hiding this comment.
Is the idea that matched_adjustment is the most recent element of sorted_parsed_name_adjustments? If so, it looks like max takes a key function.
jmsilverman
reviewed
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.