-
Notifications
You must be signed in to change notification settings - Fork 217
fix(nimbus): make home page cards equal height #14201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix(nimbus): make home page cards equal height #14201
Conversation
|
@yadneshx17 Thank you for working on this, can you run command |
|
I ran |
I know one quick work around, okay can you temporarily remove "react-app" in experimenter/results->package.json line, then run make code_format and then add the react app back again |
|
Tried that approach and reran |
yashikakhurana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh you have some unrelated files in the changes 👀
e05d31b to
65a9242
Compare
|
I have removed the unrelated changes and updated the PR. |
yashikakhurana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yadneshx17 overall looks good, one thing I noticed that the space is between the pagination, can you add padding at the top of the paginations
65a9242 to
ea13cec
Compare
|
Added top padding above pagination, let me know if this looks better. |
|
Thank you @yadneshx17 we are blocking on all the merges now, but will be back on 5th january, team is away for Christmas break 🎄 |
Because
This commit
align-items-stretchFixes #14029