Skip to content

Conversation

@yadneshx17
Copy link

Because

  • The Nimbus home page cards render with inconsistent heights when their content differs, leads to visible gaps and misaligned layout.

This commit

  • updates the home page card row to use align-items-stretch
  • converts card containers to a flex-based column layout
  • removes the fixed minimum height and relies on flexible sizing
  • ensures empty and populated card states align consistently

Fixes #14029

@yashikakhurana
Copy link
Contributor

@yadneshx17 Thank you for working on this, can you run command make code_format command to format the files correctly

@yadneshx17
Copy link
Author

yadneshx17 commented Dec 16, 2025

I ran make code_format as requested. It fails locally due to ESLint not finding the "react-app" config in the "@experimenter/results" workspace.
I also ranyarn workspace @experimenter/nimbus_ui format inside the dev container, all files were unchanged.

@yashikakhurana
Copy link
Contributor

I ran make code_format as requested. It fails locally due to ESLint not finding the "react-app" config in the "@experimenter/results" workspace. I also ranyarn workspace @experimenter/nimbus_ui format inside the dev container, all files were unchanged.

I know one quick work around, okay can you temporarily remove "react-app" in experimenter/results->package.json line, then run make code_format and then add the react app back again

@yadneshx17
Copy link
Author

Tried that approach and reran make code_format. Formatting completed successfully and the changes are pushed.

Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you have some unrelated files in the changes 👀

@yadneshx17 yadneshx17 force-pushed the fix/14029-nimbus-home-card-height branch from e05d31b to 65a9242 Compare December 17, 2025 06:42
@yadneshx17
Copy link
Author

I have removed the unrelated changes and updated the PR.

Copy link
Contributor

@yashikakhurana yashikakhurana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @yadneshx17 overall looks good, one thing I noticed that the space is between the pagination, can you add padding at the top of the paginations

Image

@yadneshx17 yadneshx17 force-pushed the fix/14029-nimbus-home-card-height branch from 65a9242 to ea13cec Compare December 18, 2025 20:16
@yadneshx17
Copy link
Author

Added top padding above pagination, let me know if this looks better.

@yashikakhurana
Copy link
Contributor

Thank you @yadneshx17 we are blocking on all the merges now, but will be back on 5th january, team is away for Christmas break 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Home page inconsistent card heights

3 participants