Skip to content

feature: Build Ids on Distribution Comparison View #2969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edugfilho wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feature: Build Ids on Distribution Comparison View #2969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions src/components/DistributionComparisonModal.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import { store } from '../state/store';
import routes from '../config/routes';
import { convertValueToPercentage } from '../utils/probe-utils';
import { formatToBuildID } from '../utils/formatters';
import BuildIdFormattedToDate from './explore/BuildIdFormattedToDate.svelte';

export let densityMetricType;
export let topChartData;
Expand Down Expand Up @@ -119,8 +121,7 @@
<Modal>
<div slot="trigger" let:open>
<button on:click={open} id={distViewButtonId} hidden
>Distribution comparison</button
>
>Distribution comparison</button>
</div>
<div slot="title">Distribution comparison - {$store.probe.name}</div>
<div class="outer-flex">
Expand All @@ -130,12 +131,14 @@
<SliderSwitch
bind:checked={cumulative}
label="Cumulative mode: "
design="slider"
/>
design="slider" />
{/if}
</div>
<div class="chart-fixed">
<p>Reference</p>
<p>
Reference - <BuildIdFormattedToDate
buildIdHour={topChartData.build_id} />
</p>
{#key cumulative}
{#key innerHeight}
{#key innerWidth}
Expand All @@ -145,8 +148,7 @@
density={topChartDensity}
{topTick}
{tickIncrement}
{activeCategoricalProbeLabels}
>
{activeCategoricalProbeLabels}>
<g slot="glam-body">
{#if bottomChartData}
<DistributionChart
Expand All @@ -157,8 +159,7 @@
{tickIncrement}
sampleCount={topChartSampleCount}
tooltipLocation="bottom"
{activeCategoricalProbeLabels}
/>
{activeCategoricalProbeLabels} />
{/if}
</g>
</DistributionComparisonGraph>
Expand All @@ -167,7 +168,10 @@
{/key}
</div>
<div class="chart-fixed">
<p>Hovered</p>
<p>
Hovered - <BuildIdFormattedToDate
buildIdHour={bottomChartData.build_id} />
</p>
{#key cumulative}
{#key innerHeight}
{#key innerWidth}
Expand All @@ -177,8 +181,7 @@
density={bottomChartDensity}
{topTick}
{tickIncrement}
{activeCategoricalProbeLabels}
>
{activeCategoricalProbeLabels}>
<g slot="glam-body">
{#if bottomChartData}
<DistributionChart
Expand All @@ -188,8 +191,7 @@
{topTick}
sampleCount={bottomChartSampleCount}
tooltipLocation="top"
{activeCategoricalProbeLabels}
/>
{activeCategoricalProbeLabels} />
{/if}
</g>
</DistributionComparisonGraph>
Expand All @@ -204,8 +206,7 @@
<h3 style="align-self: center;">{$store.probe.name}</h3>
<svelte:component
this={routes[$store.product].details}
showLinks={false}
/>
showLinks={false} />
</div>
</div>
<div><hr /></div>
Expand Down
23 changes: 23 additions & 0 deletions src/components/explore/BuildIdFormattedToDate.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<script>
export let buildIdHour;
</script>

<style>
.big-label__value__date {
font-weight: bold;
color: var(--cool-gray-700);
}

.big-label__value__time {
color: var(--cool-gray-600);
}
</style>

<span class="big-label__value__date">
{buildIdHour.slice(0, 4)}-{buildIdHour.slice(4, 6)}-{buildIdHour.slice(
6,
8
)}</span>
<span class="big-label__value__time">{buildIdHour.slice(8, 10)}:</span><span
class="big-label__value__time">{buildIdHour.slice(10, 12)}:</span
><span class="big-label__value__time">{buildIdHour.slice(12, 14)}</span>
23 changes: 3 additions & 20 deletions src/components/explore/ToplineRow.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import { Help } from '@graph-paper/icons';
import { tooltip as tooltipAction } from '@graph-paper/core/actions';
import { formatToBuildID } from '../../utils/formatters';
import BuildIdFormattedToDate from './BuildIdFormattedToDate.svelte';

export let value;
export let compare;
Expand Down Expand Up @@ -66,15 +67,6 @@
width: var(--space-32x);
}

.big-label__value__date {
font-weight: bold;
color: var(--cool-gray-700);
}

.big-label__value__time {
color: var(--cool-gray-600);
}

.big-label__value__compare {
color: var(--cool-gray-600);
}
Expand All @@ -92,22 +84,13 @@
<div class="big-label__label">
<slot name="label" /><span
use:tooltipAction={{ text: description, location: 'top' }}
class="data-graphic__element-title__icon"><Help size={14} /></span
>
class="data-graphic__element-title__icon"><Help size={14} /></span>
</div>
<div class="big-label__value">
{#if value}
<div>
{#if aggregationLevel === 'build_id'}
<span class="big-label__value__date">
{parsedLabel.slice(0, 4)}-{parsedLabel.slice(
4,
6
)}-{parsedLabel.slice(6, 8)}</span
>
<span class="big-label__value__time">{parsedLabel.slice(8, 10)}:</span
><span class="big-label__value__time">{parsedLabel.slice(10, 12)}:</span
><span class="big-label__value__time">{parsedLabel.slice(12, 14)}</span>
<BuildIdFormattedToDate buildIdHour={parsedLabel} />
{:else}{value}{/if}
</div>
{/if}
Expand Down