Draft
Conversation
Contributor
Author
|
You can also replace Vp8 by Vp9, it works too, but currently vp9 doesn't work on iOS 14.6 by default, you need to enable the flags in Safari -> Advanced -> Experimental Features |
Contributor
|
Makes sense. I'm 90% sure that the only reason we used to use H.264 over VP8 was for Mobile Safari support. If and when iOS supports something more modern with hardware acceleration it would be good to upgrade the default. |
Contributor
Author
|
We could also make it configurable in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm creating the PR as draft just so this have some visibility in case someone is interested. Here switching from h264 to vp8 by default for all rooms.
I don't use that myself, this was just to test that it works, and yes it works on Desktop, Android, iOS without any changes in naf-janus-adapter.
I'll keep h264 for now because I read vp8 is not hardware accelerated on iOS devices, so taking much cpu and battery.