Skip to content

feat: add measures and error rates for ads_client_operations_and_errors_hourly#1431

Merged
scholtzan merged 1 commit intomozilla:mainfrom
Almaju:add-ads-client-measures
Apr 21, 2026
Merged

feat: add measures and error rates for ads_client_operations_and_errors_hourly#1431
scholtzan merged 1 commit intomozilla:mainfrom
Almaju:add-ads-client-measures

Conversation

@Almaju
Copy link
Copy Markdown
Contributor

@Almaju Almaju commented Apr 21, 2026

Summary

Stacked on top of #1430 (depends on that PR for the view definition). Adds measures and error rates to the ads_client_operations_and_errors_hourly view:

  • Sum measures for every raw count column (operations, client errors, build cache errors, deserialization errors, HTTP cache outcomes)
  • Category totals: build_cache_errors_total, deserialization_errors_total
  • Error rate measures (formatted as percentages):
    • request_ads_error_rate, record_click_error_rate, record_impression_error_rate, report_ad_error_rate — each client error vs its matching operation
    • build_cache_error_rate — total build-cache errors vs op_new
    • deserialization_error_rate — total deserialization errors vs op_request_ads

No HTTP cache hit rate since a single cache request can have multiple outcomes, so summing them isn't a meaningful denominator.

Test plan

  • CI passes

@Almaju Almaju force-pushed the add-ads-client-measures branch from 175ed96 to fbb63dd Compare April 21, 2026 19:30
@Almaju Almaju force-pushed the add-ads-client-measures branch from fbb63dd to e27a89f Compare April 21, 2026 19:33
@scholtzan scholtzan added this pull request to the merge queue Apr 21, 2026
Merged via the queue into mozilla:main with commit 0aa7097 Apr 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants