feat: add measures and error rates for ads_client_operations_and_errors_hourly#1431
Merged
scholtzan merged 1 commit intomozilla:mainfrom Apr 21, 2026
Merged
Conversation
175ed96 to
fbb63dd
Compare
fbb63dd to
e27a89f
Compare
scholtzan
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on top of #1430 (depends on that PR for the view definition). Adds measures and error rates to the
ads_client_operations_and_errors_hourlyview:build_cache_errors_total,deserialization_errors_totalrequest_ads_error_rate,record_click_error_rate,record_impression_error_rate,report_ad_error_rate— each client error vs its matching operationbuild_cache_error_rate— total build-cache errors vsop_newdeserialization_error_rate— total deserialization errors vsop_request_adsNo HTTP cache hit rate since a single cache request can have multiple outcomes, so summing them isn't a meaningful denominator.
Test plan