Skip to content

Conversation

@camd
Copy link
Collaborator

@camd camd commented Dec 14, 2025

This is an extension of PR #9115. So that should be merged first.

I separated many of the changes into separate commits to attempt to help with reviewing. You may consider reviewing each commit separately.

Also fixed many test warnings.

@camd camd self-assigned this Dec 14, 2025
@camd camd requested review from Archaeopteryx and jmaher December 14, 2025 21:47
@camd camd force-pushed the camd/fix-default-props-deprecations branch from 17afc7b to 71fc9f4 Compare December 15, 2025 17:51
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 68.31876% with 326 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.19%. Comparing base (a82c683) to head (ef120fb).

Files with missing lines Patch % Lines
ui/job-view/pushes/Push.jsx 65.31% 77 Missing ⚠️
ui/job-view/pushes/FuzzyJobFinder.jsx 52.94% 31 Missing and 1 partial ⚠️
ui/hooks/useDebounce.js 0.00% 22 Missing and 2 partials ⚠️
ui/job-view/pushes/PushJobs.jsx 70.73% 12 Missing ⚠️
ui/intermittent-failures/DateRangePicker.jsx 0.00% 10 Missing ⚠️
ui/intermittent-failures/Layout.jsx 0.00% 10 Missing ⚠️
ui/shared/RevisionInformation.jsx 0.00% 9 Missing ⚠️
ui/job-view/pushes/PushHeader.jsx 76.47% 7 Missing and 1 partial ⚠️
ui/job-view/details/summary/SummaryPanel.jsx 0.00% 7 Missing ⚠️
ui/intermittent-failures/BugDetailsView.jsx 0.00% 5 Missing ⚠️
... and 61 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9124      +/-   ##
==========================================
+ Coverage   80.01%   81.19%   +1.17%     
==========================================
  Files         601      604       +3     
  Lines       32715    33867    +1152     
  Branches     3314     3191     -123     
==========================================
+ Hits        26178    27498    +1320     
+ Misses       6371     6213     -158     
+ Partials      166      156      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@camd camd changed the title Fix default props and brittle selectJob logic 3rd: Fix default props and brittle selectJob logic Dec 21, 2025
@camd camd force-pushed the camd/fix-default-props-deprecations branch from 71fc9f4 to 8e9839a Compare December 21, 2025 19:57
@camd camd force-pushed the camd/fix-default-props-deprecations branch from 8e9839a to ef120fb Compare December 21, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants