-
Notifications
You must be signed in to change notification settings - Fork 373
3rd: Fix default props and brittle selectJob logic #9124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
camd
wants to merge
9
commits into
master
Choose a base branch
from
camd/fix-default-props-deprecations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17afc7b to
71fc9f4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9124 +/- ##
==========================================
+ Coverage 80.01% 81.19% +1.17%
==========================================
Files 601 604 +3
Lines 32715 33867 +1152
Branches 3314 3191 -123
==========================================
+ Hits 26178 27498 +1320
+ Misses 6371 6213 -158
+ Partials 166 156 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 20, 2025
7 tasks
…use safer approach.
71fc9f4 to
8e9839a
Compare
8e9839a to
ef120fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of PR #9115. So that should be merged first.
I separated many of the changes into separate commits to attempt to help with reviewing. You may consider reviewing each commit separately.
Also fixed many test warnings.