3rd: Fix default props and brittle selectJob logic #9124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camd
requested review from
a team,
beatrice-acasandrei and
esanuandra
as code owners
camd
force-pushed
the
camd/fix-default-props-deprecations
branch
from
17afc7b to
71fc9f4
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #9124 +/- ##
==========================================
+ Coverage 80.01% 81.90% +1.88%
==========================================
Files 601 604 +3
Lines 32715 33876 +1161
Branches 3314 3192 -122
==========================================
+ Hits 26178 27746 +1568
+ Misses 6371 6006 -365
+ Partials 166 124 -42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 20, 2025
camd
changed the title
7 tasks
camd
force-pushed
the
camd/fix-default-props-deprecations
branch
2 times, most recently
from
8e9839a to
ef120fb
Compare
- Add tests/ui/App.test.jsx: Test URL transformations and routing - URL backwards compatibility (perf.html, pushhealth.html, logviewer.html) - Permalink hash preservation - Document title updates for perfherder alerts - Export verification (no react-hot-loader wrapper) - Expand tests/ui/helpers/filter.test.js: Comprehensive filter helper tests - thMatchType, thFieldChoices, thFilterDefaults constants - arraysEqual and matchesDefaults functions - hasUrlFilterChanges URL comparison - reloadOnChangeParameters and allFilterParams arrays - Add tests/ui/perfherder/App.test.jsx: Export and structure verification - Verify no hot loader wrapper (RSPack migration regression test) - Validate class component structure and lifecycle methods - Add tests/ui/push-health/App.test.jsx: Component and routing tests - Component loading and API call verification - Route handling (push, my-pushes, usage) - Export verification for RSPack migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change server command from 'yarn start' to 'pnpm start' to match the package manager migration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add tests for dayjs helper module (UTC, customParseFormat, isSameOrAfter, relativeTime plugins) - Add tests for display.js dayjs migration (toMercurialDateStr, toMercurialShortDateStr) - Add tests for taskcluster.js credential expiration with dayjs - Add tests for DateRangePicker MUI component migration - Add tests for intermittent-failures helpers (prettyDate, calculateMetrics) - Add tests for perfherder helpers (getFilledBugSummary date formatting) - Add tests for GraphsContainer and TableView date formatting - Add tests for job-view App react-resizable-panels migration 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add format:md, format:md:check, and lint:md scripts using prettier - Fix lint errors in test files: - taskcluster.test.js: Use toThrow() instead of try/catch - DateRangePicker.test.jsx: Remove jest.mock with require(), use toHaveLength() - helpers.test.jsx: Use toHaveLength() - GraphsContainer.test.jsx: Remove unused variable 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…use safer approach.
Add comprehensive test coverage for changes introduced in the defaultProps deprecation fixes: - tests/ui/hooks/useDebounce.test.js: Tests for useDebouncedValue and useDebouncedCallback hooks (17 tests) - tests/ui/hooks/useJobButtonRegistry.test.js: Tests for job button registry functions and hook lifecycle (25 tests) - tests/ui/helpers/job.test.js: Tests for getBtnClass, isReftest, isPerfTest, canConfirmFailure, isClassified, isUnclassifiedFailure, findInstance, getResultState, addAggregateFields, getTaskRunStr, getTaskRun (57 tests) - tests/ui/job-view/pushes/JobButton.test.jsx: Tests for the converted functional JobButton component (23 tests) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
camd
force-pushed
the
camd/fix-default-props-deprecations
branch
from
ef120fb to
16f56c6
Compare
- Replace require() with ES module import in job.test.js to fix global-require - Use shorthand boolean attributes (visible, intermittent) in JobButton.test.jsx 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of PR #9115. So that should be merged first.
I separated many of the changes into separate commits to attempt to help with reviewing. You may consider reviewing each commit separately.
Also fixed many test warnings.