Merged
Conversation
alexs-mparticle
requested changes
Mar 16, 2026
|
|
||
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 21.x] |
Collaborator
There was a problem hiding this comment.
The purpose of this matrix is to test a few different node versions in case there's any potential conflicts. I would use 24, 26 and 28 (if that's an option).
.github/workflows/pull-request.yml
Outdated
| strategy: | ||
| matrix: | ||
| node-version: [18.x, 20.x, 21.x] | ||
| node-version: [24.x] |
Collaborator
There was a problem hiding this comment.
Can we possibly use the reusable workflows instead? https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/web-kit-pull-request.yml
Contributor
Author
There was a problem hiding this comment.
Gave it a go, but the reusable workflow requires ESLint and there's a bunch of linter errors to fix. Think it would be better to make a separate PR.
alexs-mparticle
requested changes
Mar 16, 2026
Co-authored-by: Alex S <49695018+alexs-mparticle@users.noreply.github.com>
alexs-mparticle
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
npm now supports OIDC and requires an update to the release.yml to support this
Re ran npm install with Node v24
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)