Fix the issue of empty result on newer IPython#133
Open
DigitalPig wants to merge 1 commit intompastell:masterfrom
Open
Fix the issue of empty result on newer IPython#133DigitalPig wants to merge 1 commit intompastell:masterfrom
DigitalPig wants to merge 1 commit intompastell:masterfrom
Conversation
Author
|
Having some troubles replicating the CI build failure but looks like it is due to scipy's deprecated warnings: --- FIR_design_verb_REF.tex 2018-11-25 03:17:59.643671698 -0500
+++ FIR_design_verb.tex 2018-11-30 13:30:17.621490192 -0500
@@ -117,6 +117,15 @@
p = figure(2)
impz(a)
\end{verbatim}
+\begin{verbatim}
+/home/digitalpig/.conda/envs/pweave/lib/python3.7/site-
+packages/scipy/signal/signaltools.py:1344: FutureWarning: Using a non-
+tuple sequence for multidimensional indexing is deprecated; use
+`arr[tuple(seq)]` instead of `arr[seq]`. In the future this will be
+interpreted as an array index, `arr[np.array(seq)]`, which will result
+either in an error or a different result.
+ out = out_full[ind]
+\end{verbatim}
\includegraphics[width= \linewidth]{figures/FIR_design_verb_figure2_1.pdf}
\includegraphics[width= \linewidth]{figures/FIR_design_verb_figure2_2.pdf}It looks like scipy developers need to update their code to avoid it then. @mpastell What do you want to do with this?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should solve #132 . Basically ipython5 added a new type of message reply and that breaks the pweave.
In fact, I was wondering if we should change to capture only the
streamresponse. But that has the limitation of no parentmsg_id... :(