fix(skills): align /skills command handler with advertised subcommands#325
Open
wkramme wants to merge 1 commit intompfaffenberger:mainfrom
Open
fix(skills): align /skills command handler with advertised subcommands#325wkramme wants to merge 1 commit intompfaffenberger:mainfrom
wkramme wants to merge 1 commit intompfaffenberger:mainfrom
Conversation
Add /skills toggle and /skills help handling in the slash-command callback, keep /skills refresh behavior, and align usage/help text with actual supported subcommands.\n\nAlso extends callback coverage tests for toggle/help and usage text expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐶 What’s fixed
/skillsautocomplete/help advertised subcommands (toggle,help,refresh) that the active slash-command handler did not actually support. Users would see errors like:Unknown subcommand: toggleThis PR aligns implementation with the advertised UX and keeps behavior consistent.
✅ Changes
/skills togglehandling inagent_skillsslash callback/skills refreshhandling/skills helphandling🧪 Test evidence
Ran targeted tests:
uv run pytest -q tests/plugins/test_agent_skills_callbacks_coverage.pyuv run pytest -q tests/command_line/test_skills_completion.py tests/test_hook_manager.py -k "skills or /skills or test_custom_command"uv run pytest -q tests/plugins/test_agent_skills_callbacks_coverage.py tests/command_line/test_skills_completion.py -k "skills"All passing in local run.
Why this matters
This removes command-surface inconsistency and avoids user confusion where completion/help claims a command exists but execution rejects it.