demux_mkv: support demuxing native VC-1 streams#18077
Open
arch1t3cht wants to merge 1 commit into
Open
Conversation
Match lavf's logic for how to parse the extradata.
kasper93
approved these changes
Jun 5, 2026
kasper93
left a comment
kasper93
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks!
I will wait for ffmpeg pr to land though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match lavf's logic for how to parse the extradata.
A first-party codec mapping for VC-1 was added to Matroska in ietf-wg-cellar/matroska-specification#1080 .
See also: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/23374
This PR does not technically depend on the linked FFmpeg PR, but it might still be better to delay merging it until the FFmpeg PR is merged, in case some issues with the implementation come up.