Skip to content

f_auto_filters: destroy deint filter immediately on format change #18099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dudemanguy merged 1 commit into from
Jun 17, 2026
+7 −4
Merged

f_auto_filters: destroy deint filter immediately on format change #18099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions filters/f_auto_filters.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,15 @@ static void deint_process(struct mp_filter *f)
bool filter_needed = opts->deinterlace == 1 ||
(opts->deinterlace == -1 && (p->interlaced_frame || p->sub.filter));

// If the image format changed, or if we no longer need a filter,
// destroy any existing filter.
if (img->imgfmt != p->prev_imgfmt || (p->sub.filter && !filter_needed)) {
// If the image format changed, destroy any existing filter immediately since
// it may not support the new format. If we no longer need a filter, drain
// and destroy it gracefully.
if (img->imgfmt != p->prev_imgfmt) {
mp_subfilter_destroy(&p->sub);
p->prev_imgfmt = img->imgfmt;
} else if (p->sub.filter && !filter_needed) {
if (!mp_subfilter_drain_destroy(&p->sub))
return;
p->prev_imgfmt = img->imgfmt;
}

// If no filter is needed or if the filter is already inserted and we reach
Expand Down
Loading