Fix slop reports#18108
Merged
Merged
Conversation
N-R-K
reviewed
Jun 10, 2026
kasper93
reviewed
Jun 12, 2026
| memcpy(s->buf_overlap, | ||
| s->buf_queue + bytes_off + s->bytes_stride, | ||
| s->bytes_overlap); | ||
| if (s->output_overlap) |
Member
There was a problem hiding this comment.
I guess you can put this memcpy into the if above, that's it's there already. Also make sure it works correctly after this change.
Contributor
Author
There was a problem hiding this comment.
The right check is actually if (s->buf_overlap && s->bytes_overlap), similar to how it's in af_scaletempo_reset. I've verified that things work
Overlap can be disabled with overlap=0 or very small stride values which cause calculated overlap size to truncate down to 0. Fixes: mpv-player#18107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.