vo: always set request_redraw when player is paused

[seishun]

This fixes a rare race condition where render_frame clears
request_redraw right before the player is paused.

[Dudemanguy]

Do you have a way to reproduce the race in question? I don't mind if I have to run it a bazillion times to see it.

[github-actions]

Download the artifacts for this pull request:

Windows

• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-aarch64-pc-windows-msvc
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-aarch64-pc-windows-msvc-pdb
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-i686-w64-mingw32
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-x86_64-pc-windows-msvc
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-x86_64-pc-windows-msvc-pdb
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-x86_64-w64-mingw32

macOS

• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-macos-14-arm
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-macos-15-arm
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-macos-15-intel
• mpv-v0.41.0-dev-g67994a6e2-pr18118-27427367220-macos-26-arm

[seishun]

Load a video with this script and seek a few seconds before the end:

function on_eof_reached(name, value) {
    if (value == true) {
        mp.osd_message("finished watching");
    }
}
mp.observe_property("eof-reached", "bool", on_eof_reached);

[Dudemanguy]

Hmm not seeing anything. I'm seeking one second from the end and I presume the race would eventually show finished watching, but that isn't coming up. But the player doesn't pause in this test so I'm not sure how it would be an example of the race in the first place?

[seishun]

The player pauses when the end of playback is reached (with --keep-open enabled). That should show the message, which the race prevents.

[Dudemanguy]

So the test I'm doing is this with --keep-open:

function on_eof_reached(name, value)
    if value == true then
        mp.osd_message("finished watching");
        mp.commandv("seek", "-1", "exact")
    end
end

mp.observe_property("eof-reached", "bool", on_eof_reached);

And so far I've seen the message every time.

[seishun]

Right, because seeking causes a redraw. Try this:

function on_eof_reached(name, value)
    if value == true then
        mp.osd_message("finished watching")
        mp.add_timeout(1, function()
            mp.commandv("seek", "-1", "exact")
            mp.set_property("pause", "no")
        end)
    end
end

mp.observe_property("eof-reached", "bool", on_eof_reached)

[Dudemanguy]

Ran that for a few minutes but I still see the message every time. Does that script show the race for you?

[seishun]

It does but not with every video. I can reproduce the race with this one, for instance: https://x.com/mushokutensei_A/status/2062482077174677970