command: namespace bitmap overlays by owner#18133
Conversation
So you didn't run the code? |
| while (cmd->num_overlays > 0) { | ||
| talloc_free(cmd->overlays[0].source); | ||
|
|
||
| MP_TARRAY_REMOVE_AT(cmd->overlays, | ||
| cmd->num_overlays, | ||
| 0); | ||
| } |
There was a problem hiding this comment.
this isn't even indented properly, what are you doing?
There was a problem hiding this comment.
Fixed in the latest push, thanks
|
I didn't perform a runtime test of the overlay functionality |
Why? |
Signed-off-by: dnyanesh1011 <dnyaneshwarxi@gmail.com>
dnyanesh1011
force-pushed
the
overlay-owner-fix
branch
from
f83ac8e to
4411aa4
Compare
At least have the courtesy to test if it actually fixes the issue that you claim it fixes before submitting the PR. |
|
your commit has cosmetic changes mixed in, please ask your LLM to keep only required changes. Also ask it to generate a test case to actually verify the code it spit out works according to itself at least |
|
I created a minimal IPC-based reproduction and runtime-tested the patch test: opened two independent IPC clients connected to the same mpv instance result: Both overlays were visible simultaneously demonstrating that identical IDs from different clients no longer collide Cleanup test: Closed client A's IPC connection result: client A's overlay was removed automatically This matches the intended behavior described in #17534 |
4 participants
Fixes #17534
Bitmap overlays created with overlay-add currently use a global ID namespace shared by all clients. As a result, different clients using the same overlay ID can overwrite each other's overlays
Track bitmap overlays by (owner, id) instead of treating overlay IDs as globally unique. This allows multiple clients to use the same overlay IDs without interference
Additionally, remove bitmap overlays when their owning client is destroyed, matching the cleanup behavior of osd-overlay overlays
Tested by: