stream/dvdnav: fix NULL deref and wrong buffer in navigation event handling#18140
Open
hyder365 wants to merge 1 commit into
Open
stream/dvdnav: fix NULL deref and wrong buffer in navigation event handling#18140hyder365 wants to merge 1 commit into
hyder365 wants to merge 1 commit into
Conversation
Member
|
This is already fixed in my WIP branch with DVD menu support, which I expect to finalize soon. There is no need to rush those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dvdnav_get_current_nav_pci can return NULL on a malformed DVD; the return value was dereferenced without a check. Also, the DVDNAV_VTS_CHANGE handler read event data from s->buffer (stale stream buffer) instead of the fresh event buffer buf, unlike the correct DVDNAV_CELL_CHANGE handler.