bitmap_packer: return -1 instead of aborting on invalid bitmap size#18143
Merged
Conversation
All current callers of this already handle the -1 case like an error, so instead of killing everything just return -1.
kasper93
reviewed
Jun 16, 2026
Ideally we would properly log this with mp_log but the plumbing for that was deemed too ugly and not really worth it for just this one mysterious edge case. So instead, drop the fprintf business since we really shouldn't be doing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All current callers of this already handle the -1 case like an error, so instead of killing everything just return -1.