Skip to content

🐞 Don't let no-op actions clobber the cached base frame (grow-from-zero) #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bit-saver wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

🐞 Don't let no-op actions clobber the cached base frame (grow-from-zero) #1117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Loop/Window Management/Window Manipulation/ResizeContext.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,18 @@ final class ResizeContext {
}

private func recomputeTargetFrame() {
// No-op / no-frame actions (.noAction, .noSelection, .cycle, .minimize, .hide) and
// window-focus actions return a zero-size sentinel from `getFrame`. Caching that
// sentinel would clobber `cachedTargetFrame.raw`, which grow/shrink/move actions use
// as their base frame while nothing has been applied yet (preview-only chords) —
// making a subsequent grow resize from a zero-size box at screen center instead of
// the window's real frame. Preserve the previously-cached real frame for these.
let noFrameActions: [WindowDirection] = [.noAction, .noSelection, .cycle, .minimize, .hide]
guard !noFrameActions.contains(action.direction), !action.direction.willFocusWindow else {
needsRecompute = false
return
}

let result = WindowFrameResolver.getFrame(resizeContext: self)

let normalized = CGRect(
Expand Down