Skip to content

"Closure Compiler not found!" by the not "en*" locales #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaa76 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

"Closure Compiler not found!" by the not "en*" locales #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69aa776
.gitignore added
Apr 5, 2013
b05dd83
the message "is not a valid option" removed as locale specific
Apr 5, 2013
6562b33
README replaced w/ README.md
Apr 5, 2013
bbb1652
added composer.json
Apr 5, 2013
757d6d3
gitignore extended
Apr 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
/.settings
/.buildpath
/.project
/README
13 changes: 0 additions & 13 deletions README
View file
Open in desktop

This file was deleted.

3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# phing-tasks

forked from https://github.com/mrowl/phing-tasks
7 changes: 7 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"name": "phing/phing-tasks",
"description": "tasks created or borrowed for phing.",
"type": "library",
"keywords": ["phing", "tasks"],
"minimum-stability": "dev"
}
2 changes: 1 addition & 1 deletion tasks/my/JsCompileTask.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ public function main()
}
$commandBase = 'java -jar ' . $this->compilerPath;
exec($commandBase . ' --helpshort 2>&1', $output);
if (!preg_match('/"--helpshort" is not a valid option/', implode('', $output))) {
if (!preg_match('/"--helpshort" /', implode('', $output))) {
throw new BuildException('Closure Compiler not found!');
}
foreach ($this->filesets as $fs) {
Expand Down